GNOME Bugzilla – Bug 683577
strange error notification
Last modified: 2012-12-05 15:25:10 UTC
Created attachment 223765 [details] screenshot Successfully printed something out yesterday and saw this notification.
Created attachment 230762 [details] [review] blacklist some printer state reasons Hi, this patch fixes the problem. It blacklists reasons which should not be shown to users. This bug is also related to https://bugzilla.redhat.com/show_bug.cgi?id=883401. Regards Marek
Review of attachment 230762 [details] [review]: The commit subject should be the user-visible impact, eg. "Don't show strange notifications when printing" ::: plugins/print-notifications/gsd-print-notifications-manager.c @@ +686,3 @@ + if (!known_reason && + (!g_str_equal (data, "none") && + /* These reasons should not be shown to users (rhbz#883401) */ Move all that to a separate function.
Created attachment 230765 [details] [review] Don't show strange notifications when printing (In reply to comment #2) > Review of attachment 230762 [details] [review]: > > The commit subject should be the user-visible impact, eg. "Don't show strange > notifications when printing" Done. > Move all that to a separate function. Done.
Review of attachment 230765 [details] [review]: ::: plugins/print-notifications/gsd-print-notifications-manager.c @@ +265,3 @@ +static gboolean +reason_is_blacklisted (const gchar *reason) { + if (g_str_equal (reason, "none") || You can split those up. @@ +272,3 @@ + return TRUE; + } + else { No need for an else branch if you reverse the checks.
Fixed in gnome-3-6 and master commit 66f5934a8f6185b172fc9db9ce743b4f78188296 Author: Marek Kasik <mkasik@redhat.com> Date: Wed Dec 5 15:54:07 2012 +0100 print-notifications: Don't show strange notifications when printing Don't show notifications for: - cups-remote-* - other - com.apple.print.recoverable printer state reasons. "cups-remote-*" are not real errors: https://bugzilla.redhat.com/show_bug.cgi?id=883401 https://bugzilla.gnome.org/show_bug.cgi?id=683577 "other" can be emitted for no reason: https://bugzilla.redhat.com/show_bug.cgi?id=520815 "com.apple.print.recoverable" is for internal use only.