After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683544 - a11y: Whitespace in the zoom options dialog is not right
a11y: Whitespace in the zoom options dialog is not right
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Universal Access
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-06 23:19 UTC by Matthias Clasen
Modified: 2012-09-13 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch (5.69 KB, patch)
2012-09-12 20:02 UTC, Matthias Clasen 		accepted-commit_now Details | Review
how it looks (39.99 KB, image/png)
2012-09-12 20:03 UTC, Matthias Clasen 		  Details
how it looks, 2 (26.56 KB, image/png)
2012-09-12 20:03 UTC, Matthias Clasen 		  Details
how it looks, 3 (27.63 KB, image/png)
2012-09-12 20:04 UTC, Matthias Clasen 		  Details

Description Matthias Clasen 2012-09-06 23:19:25 UTC 
There's too little padding and spacing in various places in this dialog, and the content does not line up with the actions.
Comment 1 Jakub Steiner 2012-09-11 18:13:53 UTC 
I think the layout issues come from the text being bigger. The dialog would probably look a lot more balanced if it used standard sized labels.

There is a separate functionality to make text larger (but surprisingly it doesn't use a larger text label). While I can see the reasoning why to make the text more legible, the one thing that needs to be bigger is the on/off switch to enable zooming.
Comment 2 Matthias Clasen 2012-09-12 20:02:56 UTC 
Created attachment 224143 [details] [review]
a patch
Comment 3 Matthias Clasen 2012-09-12 20:03:17 UTC 
Created attachment 224144 [details]
how it looks
Comment 4 Matthias Clasen 2012-09-12 20:03:39 UTC 
Created attachment 224146 [details]
how it looks, 2
Comment 5 Matthias Clasen 2012-09-12 20:04:01 UTC 
Created attachment 224147 [details]
how it looks, 3
Comment 6 Bastien Nocera 2012-09-13 10:19:02 UTC 
Review of attachment 224143 [details] [review]:

Looks good apart from the bizarre xalign value.

::: panels/universal-access/zoom-options.ui
@@ +95,3 @@
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
+                <property name="xalign">0.47999998927116394</property>

0.5?
Comment 7 Matthias Clasen 2012-09-13 10:38:08 UTC 
not needed, i just removed it