After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683542 - Missing frame around input field
Missing frame around input field
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
6.5.x
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
3.6.1
Depends on:
Blocks:
 
 
Reported: 2012-09-06 22:44 UTC by Matthias Clasen
Modified: 2012-09-30 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: add a shadow around the scrolled window (1.19 KB, patch)
2012-09-13 20:26 UTC, Cosimo Cecchi 		reviewed Details | Review
before (29.70 KB, image/png)
2012-09-29 19:51 UTC, Matthias Clasen 		  Details
before, hc (23.59 KB, image/png)
2012-09-29 19:51 UTC, Matthias Clasen 		  Details
after (30.21 KB, image/png)
2012-09-29 19:52 UTC, Matthias Clasen 		  Details
after, hc (23.65 KB, image/png)
2012-09-29 19:52 UTC, Matthias Clasen 		  Details

Description Matthias Clasen 2012-09-06 22:44:39 UTC 
The text field has a white background. In hicontrast, the background of the window is white too, and there's no frame around the entry.
Comment 1 Matthias Clasen 2012-09-06 22:45:15 UTC 
Also the hicontrast calculator icon in Alt-Tab looks fuzzy
Comment 2 Cosimo Cecchi 2012-09-07 18:23:07 UTC 
I don't get the fuzzy icon here...I'm not sure what we can do about the entry; it has no frame even with Adwaita.
In the HighContrast theme it happens that the background color for the window and text fields are the same, so you don't see a separation between them. I think gcalctool should generally set/draw a frame around that field though, reassigning.
Comment 3 Jakub Steiner 2012-09-10 15:53:30 UTC 
I think a border would be nice for both the default and HC theme here. I wasn't able to figure out a selector for this though :(
Comment 4 Cosimo Cecchi 2012-09-13 20:26:47 UTC 
Created attachment 224273 [details] [review]
window: add a shadow around the scrolled window

So that themes can render a frame.
Comment 5 Robert Roth 2012-09-21 13:07:28 UTC 
Review of attachment 224273 [details] [review]:

Nice and clean, working fix.
Comment 6 Matthias Clasen 2012-09-27 17:19:24 UTC 
Should we get this landed, now 3.6.0 is out ?
Comment 7 Robert Ancell 2012-09-28 02:17:24 UTC 
Someone will need to do the a UI freeze exception...
Comment 8 Matthias Clasen 2012-09-29 19:51:24 UTC 
Created attachment 225395 [details]
before
Comment 9 Matthias Clasen 2012-09-29 19:51:48 UTC 
Created attachment 225396 [details]
before, hc
Comment 10 Matthias Clasen 2012-09-29 19:52:06 UTC 
Created attachment 225397 [details]
after
Comment 11 Matthias Clasen 2012-09-29 19:52:25 UTC 
Created attachment 225398 [details]
after, hc
Comment 12 Matthias Clasen 2012-09-29 19:54:29 UTC 
freeze break request sent
Comment 13 Matthias Clasen 2012-09-30 17:41:33 UTC 
And approved on the list.