GNOME Bugzilla – Bug 683526
Panel extension items are out of order when coming back from the lock screen
Last modified: 2012-09-06 19:39:16 UTC
What happens? The panel delays its update until the end of the first phase of tweening, but by that time the extension are already enabled again, and thus the order of elements is wrong. The right fix, IMHO, is to ditch the distracting animation of the panel, and do an atomic update. Since the panel is constructed before the extension system, and since signal connections are called in order, by the time extensions are enabled again, the panel is already enabled.
Created attachment 223695 [details] [review] Revert "userMenu: Don't update the presence icon immediately" This reverts commit f1ca96bbf0c56a5eaa135c777045bddb4290cebe. We're moving towards atomic panel upgrade, so we don't need this.
Created attachment 223696 [details] [review] Panel: don't animate session mode switches It causes problems with extensions, and it's excessively distracting.
Review of attachment 223696 [details] [review]: I thought the sudden flash before the shield had dropped all the way was more distracting, but whatever. ::: js/ui/panel.js @@ +966,3 @@ { sortGroup: CtrlAltTab.SortGroup.TOP }); + Main.sessionMode.connect('updated', Lang.bind(this, this._updatePanel)); I prefer having the method named "_sessionUpdated", but whatever. @@ +1133,1 @@ _closeIndicatorMenus: function() { You can remove closeIndicatorMenus now, too.
Review of attachment 223695 [details] [review]: OK.
(In reply to comment #3) > Review of attachment 223696 [details] [review]: > > I thought the sudden flash before the shield had dropped all the way was more > distracting, but whatever. I don't know. It's not flashing (we double buffer, it never goes text-black-text), and to me, the "attention" of the user is on the screenshield going down, not on the panel. Even if I keep my eyes on it, my impression is that the other indicators are pushed away by my name. On the other hand, if the panel is animating, my attention is drawn to it, in particular in the mode switch from the lock screen to the unlock dialog (where indicators don't even move, btw). I'm not a designer though, so I could be totally wrong.
Attachment 223695 [details] pushed as 657887b - Revert "userMenu: Don't update the presence icon immediately" Attachment 223696 [details] pushed as 8c53416 - Panel: don't animate session mode switches