After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683522 - Avoid critical if returning to collection view early
Avoid critical if returning to collection view early
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-06 18:16 UTC by Alexander Larsson
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix critical error when exiting display mode early (2.00 KB, patch)
2012-09-06 18:21 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2012-09-06 18:16:51 UTC 
If you go back to the collection view really fast, before the zoom from CREDS to DISPLAY is done you get a:
(gnome-boxes:32269): Boxes-CRITICAL **: boxes_display_get_display: assertion `self != NULL' failed

Because the timeout set up to switch to display mode after the animation is not cleaned up.
Comment 1 Alexander Larsson 2012-09-06 18:21:29 UTC 
Created attachment 223681 [details] [review]
Fix critical error when exiting display mode early

If you go back to the collection view really fast, before the zoom
from CREDS to DISPLAY is finished you get an critical:

(gnome-boxes:32269): Boxes-CRITICAL **: boxes_display_get_display: assertion `self != NULL' failed

This is because the timeout set up to switch to display mode after the
animation is not cleaned up. Fix this by removing the timeout when
disconnecting the show signal handler.
Comment 2 Marc-Andre Lureau 2012-09-06 19:46:52 UTC 
Review of attachment 223681 [details] [review]:

ack
Comment 3 Alexander Larsson 2012-09-07 05:44:30 UTC 
Attachment 223681 [details] pushed as f4505d6 - Fix critical error when exiting display mode early