After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683474 - Print dialog lists custom paper sizes twice for "Print to file"
Print dialog lists custom paper sizes twice for "Print to file"
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-09-06 09:55 UTC by Marek Kašík
Modified: 2012-09-06 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't load custom paper sizes in file backend (882 bytes, patch)
2012-09-06 09:57 UTC, Marek Kašík
committed Details | Review

Description Marek Kašík 2012-09-06 09:55:48 UTC
File backend loads custom paper sizes even if print dialog adds them itself later. Moreover it adds them with wrong (default ones) margins. The ones added by the dialog are correct.
Attached patch fixes this by not loading custom page sizes by file print backend.

Marek
Comment 1 Marek Kašík 2012-09-06 09:57:47 UTC
Created attachment 223619 [details] [review]
Don't load custom paper sizes in file backend
Comment 2 Matthias Clasen 2012-09-06 12:23:32 UTC
Review of attachment 223619 [details] [review]:

Looks fine to me.
Comment 3 Marek Kašík 2012-09-06 12:38:55 UTC
Comment on attachment 223619 [details] [review]
Don't load custom paper sizes in file backend

I've committed the patch to the master.