After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683471 - All gestures get cancelled after missing a button release event
All gestures get cancelled after missing a button release event
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterAction
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-06 09:20 UTC by Emanuele Aina
Modified: 2012-09-06 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gesture-action: unregister point on missed release events (1.09 KB, patch)
2012-09-06 09:21 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2012-09-06 09:20:46 UTC 
When releasing the mouse button outside of the current window the button release event is lost and GestureAction will cancel the gesture on the first motion event with no button pressed.

Due to a missing gesture_unregister_point() GestureAction will then get very confused and will cancel all subsequent gesture, even if they are perfectly legit.
Comment 1 Emanuele Aina 2012-09-06 09:21:47 UTC 
Created attachment 223615 [details] [review]
gesture-action: unregister point on missed release events

When we miss button release events (eg. when they happen outside
of our window) we must ensure that the corresponding point is
removed from the array of tracked points, otherwise GestureAction
will get very confused and will cancel all subsequent gestures.
Comment 2 Emmanuele Bassi (:ebassi) 2012-09-06 11:10:53 UTC 
Review of attachment 223615 [details] [review]:

looks good.
Comment 3 Emmanuele Bassi (:ebassi) 2012-09-06 11:19:29 UTC 
Attachment 223615 [details] pushed as 9caf9ff - gesture-action: unregister point on missed release events