GNOME Bugzilla – Bug 683467
Deleted boxes in gnome-shell search results
Last modified: 2016-03-31 14:02:09 UTC
The shell search function is listing deleted boxes, because the configuration isn't removed from the .ini file.
Created attachment 223613 [details] [review] Delete configuration when deleting a machine If we keep the configuration around, it will show up in search results.
Created attachment 223614 [details] [review] Delete screenshots from deleted machines
Review of attachment 223613 [details] [review]: Would be nicer to avoid sync IO... Also, would it be possible to cleanup the configuration file at startup by comparing what's in there with the libvirt VM we have available? Or does it require a spice connection?
Review of attachment 223614 [details] [review]: Same small comment about sync IO, though in this case it seems there are no async delete helpers in glib.
(In reply to comment #3) > Review of attachment 223613 [details] [review]: > > Would be nicer to avoid sync IO... Also, would it be possible to cleanup the > configuration file at startup by comparing what's in there with the libvirt VM > we have available? Or does it require a spice connection? gnome-boxes-search-provider doesn't connect to libvirt, but only uses locally saved information (it links only with glib), in order to return results quickly and be lightweight. It would be nice to do sync clean-up when Boxes is started. Also these patches will probably not be sufficient if you delete VM outside of Boxes, in which case the sync clean-up code would be really helpful. We should open a seperate bug for that, with lower priority.
Attachment 223613 [details] pushed as 8d14d20 - Delete configuration when deleting a machine Attachment 223614 [details] pushed as ad96c19 - Delete screenshots from deleted machines
(In reply to comment #5) > (In reply to comment #3) > > Review of attachment 223613 [details] [review] [details]: > > > > Would be nicer to avoid sync IO... Also, would it be possible to cleanup the > > configuration file at startup by comparing what's in there with the libvirt VM > > we have available? Or does it require a spice connection? > > gnome-boxes-search-provider doesn't connect to libvirt, but only uses locally > saved information (it links only with glib), in order to return results quickly > and be lightweight. > > It would be nice to do sync clean-up when Boxes is started. Also these patches > will probably not be sufficient if you delete VM outside of Boxes, in which > case the sync clean-up code would be really helpful. We should open a seperate > bug for that, with lower priority. Yes, by 'startup', I meant 'Boxes startup', this was not about the search provider.