GNOME Bugzilla – Bug 683424
Zoom in animation on starting box is broken on second try
Last modified: 2016-03-31 13:54:08 UTC
When clicking on a box the first time it zooms to the center. But the second (and after) time it stays in place. This seems to be a regression in how clutter handles BinLayout stuff due to deprecations. I've attached a port of boxes BinLayout use to not use the deprecated BinLayout.add and corresponding alignments, instead directly using actor.x/y_align etc. This fixes the issue.
Created attachment 223546 [details] [review] Fix zoom in animation when starting box. When clicking on a box the first time it zooms to the center. But the second (and after) time it stays in place. Dropping the deprecated ClutterBinAlignment stuff and using the new clutter 1.12 ClutterActor.x/y_align properties fixes this.
Review of attachment 223546 [details] [review]: ::: src/libvirt-machine.vala @@ +32,3 @@ update_display (); display.connect_it (); + _connect_display = true; that shouldn't be there
Review of attachment 223546 [details] [review]: - the position in properties page is wrong - it doesn't animate back to the collection item but to the center
Created attachment 223637 [details] [review] Fix zoom in animation when starting box. When clicking on a box the first time it zooms to the center. But the second (and after) time it stays in place. Dropping the deprecated ClutterBinAlignment stuff and using the new clutter 1.12 ClutterActor.x/y_align properties fixes this.
Updated patch without the leftover _connect_display change. However, it does animate to the right place for me, and the property page position seems right to me. Also, I built this on another box that had an earlier clutter, and the original bug didn't appear until I built the latest clutter. Marc-Andre: What clutter version did you try with? I have current git master which seems to be essentially 1.11.14.
Fwiw, I was seeing the issue you described in this bug, and your patch fixes it. I'm not seeing the issues Marc-André describes.
(In reply to comment #5) > Marc-Andre: What clutter version did you try with? I have current git master > which seems to be essentially 1.11.14. Apparently I was using, 1.11.10-2-g2c20de0. After update to git master, it seems to work ok (not really better than before anyway). We should bump clutter dependency if we apply this patch I guess? (the patch doesn't apply cleanly anymore, but manually with patch)
Created attachment 223642 [details] [review] Fix zoom in animation when starting box. When clicking on a box the first time it zooms to the center. But the second (and after) time it stays in place. Dropping the deprecated ClutterBinAlignment stuff and using the new clutter 1.12 ClutterActor.x/y_align properties fixes this. This also bumps the clutter requirement as this seems to only work on the most recent versions.
New rebased patch with clutter dependency raised
Review of attachment 223642 [details] [review]: ack
Attachment 223642 [details] pushed as 4e99713 - Fix zoom in animation when starting box.