GNOME Bugzilla – Bug 683400
Misc fixes to session mode and component system
Last modified: 2012-09-05 14:14:30 UTC
See patches
Created attachment 223512 [details] [review] Don't start new components when activating the screen-shield in gdm Previous code was activating the networkAgent and telepathyClient in the lock-screen, irrespective of the previous mode. Now it checks if the session mode is locked down, and if so it refuses to start new components.
Created attachment 223513 [details] [review] SessionMode: add polkit to gdm session It's needed to shutdown when other users are logged in or inhibitors are active.
Review of attachment 223513 [details] [review]: I'm sort of glad a "fix" is just this easy now. OK.
Review of attachment 223512 [details] [review]: um, why was it activating the network agent and telepathy client in the lock screen? We have a mode for the lock screen, and it turns all of that off, right?
Also, don't we want the telepathy client in the lock screen? Just locking your computer shouldn't log you off of IM.
(In reply to comment #4) > Review of attachment 223512 [details] [review]: > > um, why was it activating the network agent and telepathy client in the lock > screen? We have a mode for the lock screen, and it turns all of that off, > right? Maybe the commit message wasn't clear enough, but I referred to the gdm lock screen (the one that falls after 10 minutes in the greeter). They share the same session mode, so the network agent and telepathy client are activated, as they're in components list. Obviously for the user lock screen we want telepathy to be active, that's kind of the point of having notifications there.
(In reply to comment #6) > Maybe the commit message wasn't clear enough, but I referred to the gdm lock > screen (the one that falls after 10 minutes in the greeter). They share the > same session mode, so the network agent and telepathy client are activated, as > they're in components list. > Obviously for the user lock screen we want telepathy to be active, that's kind > of the point of having notifications there. I did not even know that existed.
It's not the first time I hear that from you :) So, how's the patch then?
I'm a bit disappointed in it, but my other thoughts were awful, so, good to go.
Review of attachment 223512 [details] [review]: Sigh. Fine.
Attachment 223512 [details] pushed as f957ae7 - Don't start new components when activating the screen-shield in gdm Attachment 223513 [details] pushed as 0725a7d - SessionMode: add polkit to gdm session