GNOME Bugzilla – Bug 683367
[regression] build failure: hal-pool.c:26:27: fatal error: gvfsdbusutils.h: No such file or directory
Last modified: 2012-09-19 15:45:51 UTC
I'm trying to build today's gvfs-1.13.8. The build dies with: /usr/bin/gcc -DHAVE_CONFIG_H -I. -I../.. -I/opt/garnome-3.5.90/include -DG_LOG_DOMAIN=\"GVFS-Hal\" -I../../common -I../../monitor/proxy -pthread -I/opt/garnome-3.5.90/include/glib-2.0 -I/opt/garnome-3.5.90/lib/glib-2.0/include -I/opt/garnome-3.5.90/include/gio-unix-2.0/ -DDBUS_API_SUBJECT_TO_CHANGE -I/opt/garnome-3.5.90/include/hal -I/opt/garnome-3.5.90/include/dbus-1.0 -I/opt/garnome-3.5.90/lib/dbus-1.0/include -DGIO_MODULE_DIR=\"\" -DGVFS_LOCALEDIR=\""/opt/garnome-3.5.90/share/locale"\" -I/opt/garnome-3.5.90/include -L/opt/garnome-3.5.90/lib -O2 -g -pipe -MT gvfs_hal_volume_monitor-hal-pool.o -MD -MP -MF .deps/gvfs_hal_volume_monitor-hal-pool.Tpo -c -o gvfs_hal_volume_monitor-hal-pool.o `test -f 'hal-pool.c' || echo './'`hal-pool.c hal-pool.c:26:27: fatal error: gvfsdbusutils.h: No such file or directory compilation terminated.
Same problem with gphoto2 volume monitor when compiled with HAL enabled.
David, since I'm having troubles getting HAL back into my system, would you be able to test-compile when we make the changes?
I've pushed a fix, could you please check on your side? commit 58ba8d331b4f1ae071f3fe016ad934cbfc836308 Author: Tomas Bzatek <tbzatek@redhat.com> Date: Fri Sep 14 15:41:54 2012 +0200 hal: Bring gvfsdbusutils.c back and make it private ... in order to be able to compile. gvfsdbusutils.c was removed by commit 288e9153f1f though hal still needs it for compilation. Let's make it private to hal and strip unnecessary functions. https://bugzilla.gnome.org/show_bug.cgi?id=683367
I applied the patch to a clean gvfs-1.13.8. gvfs still doesn't build. It now dies with: CCLD gvfs-hal-volume-monitor gvfs_hal_volume_monitor-hal-pool.o: In function `hal_pool_new': /home/ronis/Project/notar/GNOME/garnome/desktop/gvfs/work/main.d/gvfs-1.13.8/monitor/hal/hal-pool.c:313: undefined reference to `_g_dbus_connection_integrate_with_main' collect2: error: ld returned 1 exit status I have both gstreamer-0.10 and 1.0, dbus-1.6.4 and dbus-glib- 0.100 installed.
Created attachment 224501 [details] [review] Fix local includes Could you please test this patch? It makes the header includes more sane (some compiler could scream about wrong include paths). (In reply to comment #4) > I applied the patch to a clean gvfs-1.13.8. gvfs still doesn't build. It now > dies with: > > CCLD gvfs-hal-volume-monitor > gvfs_hal_volume_monitor-hal-pool.o: In function `hal_pool_new': > /home/ronis/Project/notar/GNOME/garnome/desktop/gvfs/work/main.d/gvfs-1.13.8/monitor/hal/hal-pool.c:313: > undefined reference to `_g_dbus_connection_integrate_with_main' > collect2: error: ld returned 1 exit status > This looks like the new files are not getting linked, the previous patch touches Makefile.am which needs to be rebuilt. AFAIK that's done automatically, but for sure you'll need to go through full automake (better to use autogen.sh from git).
The patch doesn't apply cleanly: At the top of the gvfs tree I ran: patch -p1 --dry-run < ~/0001-hal-Fix-local-includes.patch can't find file to patch at input line 15 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |From b732a1eb235c061988b2e40def0e8a038fee0d00 Mon Sep 17 00:00:00 2001 |From: Tomas Bzatek <tbzatek@redhat.com> |Date: Mon, 17 Sep 2012 14:38:12 +0200 |Subject: [PATCH] hal: Fix local includes | |--- | monitor/hal/gvfsdbusutils.c | 2 +- | monitor/hal/hal-pool.c | 2 +- | 2 files changed, 2 insertions(+), 2 deletions(-) | |diff --git a/monitor/hal/gvfsdbusutils.c b/monitor/hal/gvfsdbusutils.c |index 08a6205..648cdb5 100644 |--- a/monitor/hal/gvfsdbusutils.c |+++ b/monitor/hal/gvfsdbusutils.c ---------------------------- File to patch: Skip this patch? [y] Skipping patch. 1 out of 1 hunk ignored patching file monitor/hal/hal-pool.c ------------------------
gvfs-1.13.9 is out with the first patch, could you please test this tarball? Clearly there's something wrong with applying the patches.
It works. Thanks
OK, closing for now. Feel free to report any other build failures.