GNOME Bugzilla – Bug 683296
Port to new documentation infrastructure
Last modified: 2012-09-04 11:04:32 UTC
Created attachment 223378 [details] [review] Port to new documentation infrastructure Use yelp-tools instead of gnome-doc-utils See https://live.gnome.org/GnomeGoals/NewDocumentationInfrastructure
Review of attachment 223378 [details] [review]: It seems this patch does not update the translation files. Something like the following should do the trick: $ for i in $(find help/clock -name '*.po'); do sed -i 's|C/clock.xml|C/index.docbook|g' $i;done $ for i in $(find help/fish -name '*.po'); do sed -i 's|C/fish.xml|C/index.docbook|g' $i;done This will avoid unnecessary double work for translator.
Review of attachment 223378 [details] [review]: I wonder why git didn't show a move from clock.xml to index.docbook. Were there many changes in the file? ::: gnome-panel/panel.c @@ +700,3 @@ g_ascii_strncasecmp (uri, "ftp:", strlen ("ftp:")) == 0 || g_ascii_strncasecmp (uri, "gopher:", strlen ("gopher:")) == 0 || + g_ascii_strncasecmp (uri, "help:", strlen ("help:")) == 0 || This is actually wrong: ghelp is still a valid scheme. You should add help, but not remove ghelp. ::: help/clock/Makefile.am @@ +6,3 @@ + index.docbook \ + legal.xml + Could you also define an empty HELP_MEDIA variable? ::: help/fish/Makefile.am @@ +6,3 @@ + index.docbook \ + legal.xml + Could you also define an empty HELP_MEDIA variable?
Created attachment 223403 [details] [review] Port to new documentation infrastructure.v2 Updated patch with your comments The only change in the index.docbook page is the change of some ghelp:->help: uris
Review of attachment 223403 [details] [review]: Looks good, but I just realized that you didn't change applets/clock/clock-utils.c to use help instead of ghelp. Please commit with this additional change :-)
Comment on attachment 223403 [details] [review] Port to new documentation infrastructure.v2 committed with the little fix: commit 515d89b7ef83f1f8d8938de0ff84d4424797f478
Thanks for your fast review! :)