After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683286 - codewriter: update modification time at end of write_file()
codewriter: update modification time at end of write_file()
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 649084 773325 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-03 17:35 UTC by Marc-Andre Lureau
Modified: 2017-04-30 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codewriter: update modification time at end of write_file() (957 bytes, patch)
2012-09-03 17:36 UTC, Marc-Andre Lureau 		none Details | Review
codewriter: Update timestamps of generated c-files if needed (1.69 KB, patch)
2017-02-25 07:54 UTC, Rico Tzschichholz 		committed Details | Review

Description Marc-Andre Lureau 2012-09-03 17:35:57 UTC 
Makefile typically expect to have modified files with updated
timestamp. It solve a dependency issues and unneeded rebuilds.

Even if the content didn't change, it seems reasonable to update the
modification time in this case.
Comment 1 Marc-Andre Lureau 2012-09-03 17:36:00 UTC 
Created attachment 223353 [details] [review]
codewriter: update modification time at end of write_file()
Comment 2 Al Thomas 2017-02-24 19:03:42 UTC 
*** Bug 649084 has been marked as a duplicate of this bug. ***
Comment 3 Rico Tzschichholz 2017-02-25 07:54:47 UTC 
Created attachment 346696 [details] [review]
codewriter: Update timestamps of generated c-files if needed

If a changed source-file produces the same ccode we currently leave
existing files untouched. Although it is better to update the modification
timestamp of those to at least meet the one of associated source-file.
Comment 4 Rico Tzschichholz 2017-02-25 07:56:58 UTC 
*** Bug 773325 has been marked as a duplicate of this bug. ***
Comment 5 Rico Tzschichholz 2017-04-30 16:30:16 UTC 
Attachment 346696 [details] pushed as 3c8489c - codewriter: Update timestamps of generated c-files if needed