After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683279 - range: add a primary-button-warps-slider style property
range: add a primary-button-warps-slider style property
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-09-03 15:45 UTC by Cosimo Cecchi
Modified: 2012-09-03 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
range: add a primary-button-warps-slider style property (3.41 KB, patch)
2012-09-03 15:45 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-09-03 15:45:24 UTC 
Setting this to TRUE (it's FALSE by default) enables the behavior we
have in GTK3 for scrollbars.
Comment 1 Cosimo Cecchi 2012-09-03 15:45:26 UTC 
Created attachment 223340 [details] [review]
range: add a primary-button-warps-slider style property
Comment 2 Matthias Clasen 2012-09-03 15:49:16 UTC 
Review of attachment 223340 [details] [review]:

::: gtk/gtkrange.c
@@ +2403,2 @@
        */
+      if (range->layout->mouse_location != MOUSE_SLIDER)

Would have been more obvious to keep the condition and just go event->butotn == warp_button.
Why the change ?
Comment 3 Matthias Clasen 2012-09-03 15:53:16 UTC 
Review of attachment 223340 [details] [review]:

clarified on irc - condition matches gtk3
Comment 4 Cosimo Cecchi 2012-09-03 15:58:25 UTC 
Attachment 223340 [details] pushed as cc7abf6 - range: add a primary-button-warps-slider style property