After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683274 - spice: do not call get_pixbuf() if the display is not ready
spice: do not call get_pixbuf() if the display is not ready
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-03 14:38 UTC by Marc-Andre Lureau
Modified: 2016-03-31 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
spice: do not call get_pixbuf() if the display is not ready (1.17 KB, patch)
2012-09-03 14:38 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2012-09-03 14:38:00 UTC 
Avoid the infamous d->data != NULL critical when the display is not
ready. Sadly, get_pixbuf() doesn't raise errors, so it makes sense to
not call the function when the display is not ready.
Comment 1 Marc-Andre Lureau 2012-09-03 14:38:03 UTC 
Created attachment 223328 [details] [review]
spice: do not call get_pixbuf() if the display is not ready
Comment 2 Christophe Fergeau 2012-09-03 15:32:48 UTC 
Review of attachment 223328 [details] [review]:

Does this help in any way with bug #683042 ?

::: src/spice-display.vala
@@ +97,3 @@
+            return null;
+
+        return display.get_pixbuf ();

I assume currently null is already returned, but a critical is raised as well?
Comment 3 Marc-Andre Lureau 2012-09-03 15:59:07 UTC 
(In reply to comment #2)
> Review of attachment 223328 [details] [review]:
> 
> Does this help in any way with bug #683042 ?

No I suspect it has to do with the ready callback, I tried to look at it, but it's not easy to reproduce. It would be nice to fix indeed.

> ::: src/spice-display.vala
> @@ +97,3 @@
> +            return null;
> +
> +        return display.get_pixbuf ();
> 
> I assume currently null is already returned, but a critical is raised as well?

yes
Comment 4 Marc-Andre Lureau 2012-09-03 16:10:18 UTC 
Attachment 223328 [details] pushed as 3356877 - spice: do not call get_pixbuf() if the display is not ready