After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683273 - display-page: avoid critical if display is not set yet
display-page: avoid critical if display is not set yet
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
: 683045 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-03 14:07 UTC by Marc-Andre Lureau
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display-page: avoid critical if display is not set yet (1.33 KB, patch)
2012-09-03 14:07 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2012-09-03 14:07:11 UTC 
Boxes may want to update toolbar title before the display is set,
don't spit criticals in this case, and act appropriately.
Comment 1 Marc-Andre Lureau 2012-09-03 14:07:13 UTC 
Created attachment 223326 [details] [review]
display-page: avoid critical if display is not set yet
Comment 2 Christophe Fergeau 2012-09-03 14:16:32 UTC 
*** Bug 683045 has been marked as a duplicate of this bug. ***
Comment 3 Christophe Fergeau 2012-09-03 14:17:41 UTC 
Review of attachment 223326 [details] [review]:

Can you add the critical this fixes to the commit log? It's
(gnome-boxes:27053): Boxes-CRITICAL **: boxes_display_get_can_grab_mouse: assertion `self != NULL' failed

Is this the right fix, or are we just hiding a deeper problem that will come back to byte us later?
Comment 4 Marc-Andre Lureau 2012-09-03 14:32:39 UTC 
Review of attachment 223326 [details] [review]:

I checked the bt, and the DisplayPage.display was null when calling update_toolbar_visible(), which can happen before DisplayPage.show_display() is called in App.app.window.window_state_event handler.

I will update commit comment.
Comment 5 Christophe Fergeau 2012-09-03 14:46:12 UTC 
Review of attachment 223326 [details] [review]:

I know that this can get called with a null display, what I'm wondering is if it's normal that we try to call update_toolbar_visible before calling show_display, and if it's something we want to support, or if there's a deeper problem and update_toolbar_visible should never be called that early?
Comment 6 Marc-Andre Lureau 2012-09-03 15:03:57 UTC 
Review of attachment 223326 [details] [review]:

I don't think we need to worry much if update_toolbar_visible() is called with null display. We may want to be stricter, but then we have to move the display != null check in the window_state_event handler. Would that make more sense?
Comment 7 Christophe Fergeau 2012-09-03 15:30:30 UTC 
No clue, that's why I stopped looking at bug #683045 ;)
Comment 8 Marc-Andre Lureau 2012-09-03 16:10:08 UTC 
Attachment 223326 [details] pushed as 3c25121 - display-page: avoid critical if display is not set yet