GNOME Bugzilla – Bug 683234
Clicking city name gets white screen
Last modified: 2012-09-16 14:04:47 UTC
Clock 0.1.0 on Ubuntu 12.10 Alpha 1. Click New to add a new world clock. 2. Enter a city name, like Paris, France 3. After adding the city, click the city. The first few times I tried this, the entire app screen turned white and the error below showed up on the terminal. Although you can't see the interface, if you can manage to click something that does work like London by guessing where it is, the UI comes back. After a few times closing and reopening the app, the new cities managed to work. Traceback (most recent call last):
+ Trace 230784
self.embed.spotlight(show_standalone_page)
action()
self.toolbar.show_standalone_toolbar(widget)
self.titleLabel.set_markup("<b>%s</b>" % self.standalone.get_name())
return GLib.markup_escape_text(self.location.get_city_name())
I think this happens if we try to see the city before libgweather fetches the data: we need to fix this.
This need UI design first. Do we darken the world clock and add a spinner on it the time for libgweather to fetch data ? Or must we wait to add the clock (but in this case, the user may think it's a bug because nothing happens)
I like the idea of the spinner, though it is still not clear to me how is it possible that we have fecthed the name that we display in the iconview, but not yet fetched the data for the standalone clock...
Seems that names are fetched when searching the city in the new world clock dialog. That explain why the name is available but time, sunrise time and sunset time are not.
I noticed that this happens for newly added clocks, while it works for the clocks loaded at startup
Created attachment 224443 [details] [review] Fix white screen when adding new clock
After more investigation with Mael, it turns out that the problem is that we need to make sure te GWeather world does not get garbage collected. I fixed it in git using a singleton