After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683232 - schemas: Add keys to show extra XKB layouts and IBus engines
schemas: Add keys to show extra XKB layouts and IBus engines
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 682240 682313
 
 
Reported: 2012-09-02 23:43 UTC by Rui Matos
Modified: 2012-09-04 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
schemas: Add keys to show extra XKB layouts and IBus engines (1.26 KB, patch)
2012-09-02 23:43 UTC, Rui Matos 		needs-work Details | Review
schemas: Add a key to show all installed XKB layouts and IBus engines (1.09 KB, patch)
2012-09-03 17:07 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-09-02 23:43:02 UTC 
Patch attached.
Comment 1 Rui Matos 2012-09-02 23:43:04 UTC 
Created attachment 223230 [details] [review]
schemas: Add keys to show extra XKB layouts and IBus engines
Comment 2 Bastien Nocera 2012-09-03 15:34:26 UTC 
Review of attachment 223230 [details] [review]:

::: schemas/org.gnome.desktop.input-sources.gschema.xml.in.in
@@ +43,3 @@
+      <_summary>Use extra IBus engines</_summary>
+      <_description>
+        Use extra IBus engines.

Is it "Use extra engines", or "Display all the possible input source engines"?
Why do we need ibus in the name? Isn't that an implementation detail? Can we have a single setting for both?
Comment 3 Rui Matos 2012-09-03 17:07:50 UTC 
Created attachment 223348 [details] [review]
schemas: Add a key to show all installed XKB layouts and IBus engines

--

Only a single key to rule them all.
Comment 4 Matthias Clasen 2012-09-04 01:14:46 UTC 
Review of attachment 223348 [details] [review]:

Looks good to me
Comment 5 Bastien Nocera 2012-09-04 10:24:12 UTC 
Review of attachment 223348 [details] [review]:

++
Comment 6 Rui Matos 2012-09-04 11:51:25 UTC 
Attachment 223348 [details] pushed as 3641385 - schemas: Add a key to show all installed XKB layouts and IBus engines