After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683219 - Build failure with old (?) XI2
Build failure with old (?) XI2
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: x11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-02 18:22 UTC by Xan Lopez
Modified: 2012-09-03 07:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
x11/device-manager-xi2: Put XIPointerEmulated under conditionals (1.78 KB, patch)
2012-09-02 21:50 UTC, Emmanuele Bassi (:ebassi)
committed Details | Review

Description Xan Lopez 2012-09-02 18:22:56 UTC
There's a couple of CLUTTER_NOTE macro usages in clutter-device-manager-xi2.c that will break the build when the version of XI2 is not recent enough (I assume, Fedora 16 here). Error:

  CC     clutter-binding-pool.lo
./x11/clutter-device-manager-xi2.c: In function 'clutter_device_manager_xi2_translate_event':
./x11/clutter-device-manager-xi2.c:928:13: error: 'XIPointerEmulated' undeclared (first use in this function)
./x11/clutter-device-manager-xi2.c:928:13: note: each undeclared identifier is reported only once for each function it appears in
  CC     clutter-bin-layout.lo
make[2]: *** [clutter-device-manager-xi2.lo] Error 1

I guess this is missing either an #ifdef somewhere, or the check in configure.ac for the library should be updated.
Comment 1 Emmanuele Bassi (:ebassi) 2012-09-02 21:50:56 UTC
Created attachment 223225 [details] [review]
x11/device-manager-xi2: Put XIPointerEmulated under conditionals

There are a couple of debugging messages using XInput 2.2 symbols
unconditionally, and it breaks builds on older systems.
Comment 2 Emmanuele Bassi (:ebassi) 2012-09-03 07:49:43 UTC
Attachment 223225 [details] pushed as b2b22db - x11/device-manager-xi2: Put XIPointerEmulated under conditionals