GNOME Bugzilla – Bug 683219
Build failure with old (?) XI2
Last modified: 2012-09-03 07:49:56 UTC
There's a couple of CLUTTER_NOTE macro usages in clutter-device-manager-xi2.c that will break the build when the version of XI2 is not recent enough (I assume, Fedora 16 here). Error: CC clutter-binding-pool.lo ./x11/clutter-device-manager-xi2.c: In function 'clutter_device_manager_xi2_translate_event': ./x11/clutter-device-manager-xi2.c:928:13: error: 'XIPointerEmulated' undeclared (first use in this function) ./x11/clutter-device-manager-xi2.c:928:13: note: each undeclared identifier is reported only once for each function it appears in CC clutter-bin-layout.lo make[2]: *** [clutter-device-manager-xi2.lo] Error 1 I guess this is missing either an #ifdef somewhere, or the check in configure.ac for the library should be updated.
Created attachment 223225 [details] [review] x11/device-manager-xi2: Put XIPointerEmulated under conditionals There are a couple of debugging messages using XInput 2.2 symbols unconditionally, and it breaks builds on older systems.
Attachment 223225 [details] pushed as b2b22db - x11/device-manager-xi2: Put XIPointerEmulated under conditionals