After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683136 - Implement new mockups for the Network Menu
Implement new mockups for the Network Menu
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: network-indicator
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 658230 677142 682929
Blocks:
 
 
Reported: 2012-08-31 20:14 UTC by Giovanni Campagna
Modified: 2013-06-17 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
NetworkMenu: remove broken device activation policy (6.40 KB, patch)
2012-08-31 20:14 UTC, Giovanni Campagna
committed Details | Review
[EXPERIMENTAL] PowerMenu: add a toggle switch for controlling mobile broadband card (7.07 KB, patch)
2012-08-31 20:14 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2012-08-31 20:14:06 UTC
Meta bug to implement https://live.gnome.org/GnomeShell/Design/Guidelines/SystemStatus/Network
and to keep togheter patches that don't have specific bugs.
Comment 1 Giovanni Campagna 2012-08-31 20:14:09 UTC
Created attachment 223103 [details] [review]
NetworkMenu: remove broken device activation policy

Previously, when toggling a switch on we tried to replicate NM policy and
find a good connection to activate. This is broken in many situations.
Instead, only activate something when we can be sure it's what the user
wants (i.e. when there is only one connection, or when there is none,
and thus connecting will trigger the config dialog)
Comment 2 Giovanni Campagna 2012-08-31 20:14:44 UTC
Created attachment 223104 [details] [review]
[EXPERIMENTAL] PowerMenu: add a toggle switch for controlling mobile broadband card

The network menu no longer allows to control power to the 3G cards.
Place it in the power menu instead, and label it generically "Modem",
as it controls data, SMS, GPS and possibly other services.

Attached for design testing.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-31 20:18:07 UTC
Review of attachment 223103 [details] [review]:

Giovanni, please commit this patch, thank you

::: js/ui/status/network.js
@@ +949,3 @@
             return _("Wi-Fi");
         else
+            return getDeviceName(this.device);

Unrelated to policy changes. If intended, please split out.
Comment 4 Giovanni Campagna 2012-08-31 20:37:08 UTC
Comment on attachment 223103 [details] [review]
NetworkMenu: remove broken device activation policy

Attachment 223103 [details] pushed as 82c8aad - NetworkMenu: remove broken device activation policy
After short IRC discussion, we concluded this is desirable
indepently of the rest of the network menu relayout.
Comment 5 Matthias Clasen 2012-11-10 22:30:56 UTC
what does the rest of the network menu relayout block on ?
Comment 6 Florian Müllner 2013-06-17 10:54:20 UTC
This will be obsoleted by the combined system status menu, should we close it?
Comment 7 Allan Day 2013-06-17 13:14:34 UTC
(In reply to comment #6)
> This will be obsoleted by the combined system status menu, should we close it?

Yes.