Created attachment 223034 [details] [review]
gesture-action: Add API for cancelling a gesture

Review of attachment 223034 [details] [review]:

the API looks generally okay.

::: clutter/clutter-gesture-action.c
@@ +685,3 @@
 }
+
+guint

missing documentation.

@@ +693,3 @@
+}
+
+ClutterEventSequence *

missing documentation, and line break between arguments.

@@ +703,3 @@
+
+ClutterInputDevice *
+clutter_gesture_action_get_device (ClutterGestureAction *action, guint device)

missing documentation and line break between arguments.

@@ +711,3 @@
+}
+
+void

missing documentation.

::: clutter/clutter-gesture-action.h
@@ +119,3 @@
                                                                  gfloat               *release_y);
 
+guint           clutter_gesture_action_get_n_current_points     (ClutterGestureAction *action);

missing CLUTTER_AVAILABLE_IN_1_12 annotation.

@@ +121,3 @@
+guint           clutter_gesture_action_get_n_current_points     (ClutterGestureAction *action);
+
+ClutterEventSequence * clutter_gesture_action_get_sequence      (ClutterGestureAction *action,

missing CLUTTER_AVAILABLE_IN_1_12 annotation, and the header should be reformatted to fit everything inside columns.

@@ +124,3 @@
+                                                                 guint                 device);
+
+ClutterInputDevice * clutter_gesture_action_get_device          (ClutterGestureAction *action,

missing CLUTTER_AVAILABLE_IN_1_12 annotation.

@@ +127,3 @@
+                                                                 guint                 device);
+
+void            clutter_gesture_action_cancel                   (ClutterGestureAction *action);

missing CLUTTER_AVAILABLE_IN_1_12 annotation.

Created attachment 223084 [details] [review]
gesture-action: Add API for cancelling a gesture

and getters for sequences and devices of current points. It can be
used for accepting and rejecting sequences for system-wide gestures.

Sorry, didn't realized I had a review already, what I just attached is only rebased to current master.

Comment on attachment 223084 [details] [review]
gesture-action: Add API for cancelling a gesture

Please disregard

Created attachment 223093 [details] [review]
gesture-action: Add API for cancelling a gesture

and getters for sequences and devices of current points. It can be
used for accepting and rejecting sequences for system-wide gestures.

Review of attachment 223093 [details] [review]:

looks good to me. you can add the annotations before pushing to master.

::: clutter/clutter-gesture-action.c
@@ +830,3 @@
+ * Retrieves the #ClutterEventSequence of a touch point.
+ *
+ * Return value: the #ClutterEventSequence of a touch point.

you probably want to add (transfer none), to be on the safe side.

@@ +851,3 @@
+ * Retrieves the #ClutterInputDevice of a touch point.
+ *
+ * Return value: the #ClutterInputDevice of a touch point.

add (transfer none), same as above.

The following fixes have been pushed: