After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683089 - gnome-control-center shows encoding names for input methods.
gnome-control-center shows encoding names for input methods.
Status: RESOLVED DUPLICATE of bug 682851
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-31 10:02 UTC by Takao Fujiwara
Modified: 2012-09-05 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for gnome-region-panel-input.c (1.73 KB, patch)
2012-08-31 10:04 UTC, Takao Fujiwara 		none Details | Review
Patch for gnome-region-panel-input.c (1.91 KB, patch)
2012-09-03 02:44 UTC, Takao Fujiwara 		none Details | Review

Description Takao Fujiwara 2012-08-31 10:02:55 UTC 
gnome-control-center gets the language codes by ibus_engine_desc_get_language() and gets the readable names by gdm_get_language_from_name().

ibus_engine_desc_get_language() does not return language code (e.g. 'zh') only but also language + country code (e.g. 'zh_CN').
However gdm_get_language_from_name() uses the locale descriptions and returns unnecessary encoding names.

E.g. 'zh_TW' is not UTF-8 locale so the function returns "Chinese (Taiwan) [BIG5]".

We need to send 'zh_TW.UTF-8' to the function instead.
Comment 1 Takao Fujiwara 2012-08-31 10:04:25 UTC 
Created attachment 223032 [details] [review]
Patch for gnome-region-panel-input.c

The patch is attached.
Comment 2 Rui Matos 2012-08-31 16:23:29 UTC 
I would prefer the patch in bug 682851.
Comment 3 Takao Fujiwara 2012-09-03 02:44:33 UTC 
Created attachment 223235 [details] [review]
Patch for gnome-region-panel-input.c

(In reply to comment #2)
> I would prefer the patch in bug 682851.

I don't mind the way but it might be incompatible with GDM.
Comment 4 Bastien Nocera 2012-09-05 18:21:06 UTC 
Closing as a dupe, as Rui prefers the solution in bug 682851 for GNOME 3.6.

*** This bug has been marked as a duplicate of bug 682851 ***