After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683066 - brightness-contrast-effect: Don't actually run if it will have no effect
brightness-contrast-effect: Don't actually run if it will have no effect
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 20:07 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-09-03 08:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
brightness-contrast-effect: Don't actually run if it will have no effect (1.76 KB, patch)
2012-08-30 20:07 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-08-30 20:07:35 UTC 
See patch. This causes performance issues in gnome-shell when we have
opened too many modal dialogs.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-30 20:07:37 UTC 
Created attachment 222990 [details] [review]
brightness-contrast-effect: Don't actually run if it will have no effect

Don't run the shader and redirect to an FBO if it won't actually do anything.
This saves us on resources a ton.
Comment 2 Emmanuele Bassi (:ebassi) 2012-09-03 07:51:02 UTC 
Review of attachment 222990 [details] [review]:

looks okay.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-03 08:03:04 UTC 
Attachment 222990 [details] pushed as 38b82cb - brightness-contrast-effect: Don't actually run if it will have no effect