After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683063 - Add non-varargs version of save to stream methods
Add non-varargs version of save to stream methods
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 19:51 UTC by Cosimo Cecchi
Modified: 2016-04-06 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: bump to 2.27.0 (956 bytes, patch)
2012-08-30 19:52 UTC, Cosimo Cecchi
rejected Details | Review
Add non-varargs versions of methods to save to stream (10.14 KB, patch)
2012-08-30 19:52 UTC, Cosimo Cecchi
none Details | Review
Add non-varargs versions of methods to save to stream (10.15 KB, patch)
2012-08-30 19:54 UTC, Cosimo Cecchi
needs-work Details | Review
Add non-varargs versions of methods to save to stream (10.61 KB, patch)
2014-10-23 18:12 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2012-08-30 19:51:49 UTC
This is useful when the set of options you want to use changes according to specific conditions, and makes the stream-based API consistent with the others.
Comment 1 Cosimo Cecchi 2012-08-30 19:52:14 UTC
Created attachment 222985 [details] [review]
build: bump to 2.27.0

Since we're going to add new API
Comment 2 Cosimo Cecchi 2012-08-30 19:52:47 UTC
Created attachment 222986 [details] [review]
Add non-varargs versions of methods to save to stream

This is useful when the set of options you want to use changes according
to specific conditions, and makes the stream-based API consistent with
the others.
Comment 3 Cosimo Cecchi 2012-08-30 19:54:22 UTC
Created attachment 222987 [details] [review]
Add non-varargs versions of methods to save to stream

This is useful when the set of options you want to use changes according
to specific conditions, and makes the stream-based API consistent with
the others.

--

Fixed a missing (allow-none) annotation
Comment 4 Bastien Nocera 2014-10-21 16:38:00 UTC
Review of attachment 222985 [details] [review]:

We've already bumped many times since then...
Comment 5 Bastien Nocera 2014-10-21 16:48:19 UTC
Review of attachment 222987 [details] [review]:

::: gdk-pixbuf/gdk-pixbuf-io.c
@@ +2923,3 @@
+                                  gpointer             user_data)
+{
+	GSimpleAsyncResult *result;

This needs to be ported to using GTask, like the gdk_pixbuf_save_to_stream_async() was.
Comment 6 Cosimo Cecchi 2014-10-23 18:12:55 UTC
Created attachment 289219 [details] [review]
Add non-varargs versions of methods to save to stream

--

Updated to git master
Comment 7 Cosimo Cecchi 2016-04-05 20:49:05 UTC
Bastien, any chance we can get it in this cycle?
Comment 8 Matthias Clasen 2016-04-06 16:07:13 UTC
Review of attachment 289219 [details] [review]:

if you update the since tags, sure
Comment 9 Cosimo Cecchi 2016-04-06 17:06:05 UTC
Thanks, I pushed this to master with updated tags after bumping version and branching for 2.34.

Attachment 289219 [details] pushed as c53c470 - Add non-varargs versions of methods to save to stream