GNOME Bugzilla – Bug 683063
Add non-varargs version of save to stream methods
Last modified: 2016-04-06 17:06:07 UTC
This is useful when the set of options you want to use changes according to specific conditions, and makes the stream-based API consistent with the others.
Created attachment 222985 [details] [review] build: bump to 2.27.0 Since we're going to add new API
Created attachment 222986 [details] [review] Add non-varargs versions of methods to save to stream This is useful when the set of options you want to use changes according to specific conditions, and makes the stream-based API consistent with the others.
Created attachment 222987 [details] [review] Add non-varargs versions of methods to save to stream This is useful when the set of options you want to use changes according to specific conditions, and makes the stream-based API consistent with the others. -- Fixed a missing (allow-none) annotation
Review of attachment 222985 [details] [review]: We've already bumped many times since then...
Review of attachment 222987 [details] [review]: ::: gdk-pixbuf/gdk-pixbuf-io.c @@ +2923,3 @@ + gpointer user_data) +{ + GSimpleAsyncResult *result; This needs to be ported to using GTask, like the gdk_pixbuf_save_to_stream_async() was.
Created attachment 289219 [details] [review] Add non-varargs versions of methods to save to stream -- Updated to git master
Bastien, any chance we can get it in this cycle?
Review of attachment 289219 [details] [review]: if you update the since tags, sure
Thanks, I pushed this to master with updated tags after bumping version and branching for 2.34. Attachment 289219 [details] pushed as c53c470 - Add non-varargs versions of methods to save to stream