GNOME Bugzilla – Bug 683056
doesn't strip line return from window title
Last modified: 2013-01-16 19:28:08 UTC
Created attachment 222972 [details] screenshot If a string has an embedded new line in it we don't handle it very well.
Created attachment 222983 [details] [review] Don't allow multiline window titles
Review of attachment 222983 [details] [review]: This will cause multiline titles to have weird glyph characters in them. Is that what we want, or do we want to replace it with a space? Also, what do we do for window titles in the overview (or other places we show them, like Alt-Tab?)
I don't really see the point in trying to pretty this up that much. If the name has some weird unicode character in it then so be it. I think the important thing is that we don't break when it does. So by not break I guess I mean: * In places where we don't already wrap text - ensure we never break lines for embedded control characters either * In places where we wrap text... are there any?
Seems OK to me.
If we want to make this look better, we should fix Pango to use U+23CE ⏎ or U+240D ␍ (or something else) - and also fix it for GtkEntry, etc, rather than special-casing it in Mutter.
Review of attachment 222983 [details] [review]: I think this is good to implement
Attachment 222983 [details] pushed as 27e0e44 - Don't allow multiline window titles