After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683035 - region: Use the async IBus engines getter
region: Use the async IBus engines getter
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-30 14:10 UTC by Rui Matos
Modified: 2012-09-03 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: Use the async IBus engines getter (3.71 KB, patch)
2012-08-30 14:10 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-08-30 14:10:32 UTC 
Let's keep this separated from the blacklist/whitelist issue in bug 682313.
Comment 1 Rui Matos 2012-08-30 14:10:34 UTC 
Created attachment 222944 [details] [review]
region: Use the async IBus engines getter
Comment 2 Matthias Clasen 2012-08-30 20:20:12 UTC 
Review of attachment 222944 [details] [review]:

Looks fine to me.
Comment 3 Bastien Nocera 2012-09-03 15:52:02 UTC 
Review of attachment 222944 [details] [review]:

Other than this small comment, looks good.

::: panels/region/gnome-region-panel-input.c
@@ +211,3 @@
     }
 
+  /* Maps engine ids to engine description objects */

I think I mentioned I don't really like/understand this naming convention.
Comment 4 Rui Matos 2012-09-03 16:57:14 UTC 
Attachment 222944 [details] pushed as 7171520 - region: Use the async IBus engines getter