After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683028 - Searching is broken in MediaExport
Searching is broken in MediaExport
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
0.15.x
Other Linux
: Normal major
: ---
Assigned To: Jens Georg
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 11:13 UTC by Mark Ryan
Modified: 2012-08-30 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for search bug in MediaExport (1.40 KB, patch)
2012-08-30 11:14 UTC, Mark Ryan 		committed Details | Review

Description Mark Ryan 2012-08-30 11:13:38 UTC 
Searching has not been working in the MediaExport backend since commit bb04821.  The fix seems to be quite simple, even for a Vala newbie like myself.  

Two parameters are being passed to MediaCache.get_objects_by_search_expression in the wrong order.  To fix we simply need to pass the arguments in the correct order.  I've attached a patch with the proposed fix.

Note that I think bb04821 might have caused other problems in MediaExport.  I'm having problems getting CreateObject to work on the AnyContainer since this commit.  I thought the problems might be related to the search bug but this seems not to be the case.  I'm afraid I haven't yet had the time to investigate this issue further.
Comment 1 Mark Ryan 2012-08-30 11:14:46 UTC 
Created attachment 222922 [details] [review]
Fix for search bug in MediaExport
Comment 2 Jens Georg 2012-08-30 12:10:02 UTC 
Meh, git stash is evil, I remember fixing that, but found the fix on my stash :( Thanks.
Comment 3 Jens Georg 2012-08-30 12:23:31 UTC 
The CreateObject issue is caused by 0b1f0e and missing one place in media-export which sets the sort criteria to "";
Comment 4 Jens Georg 2012-08-30 17:29:56 UTC 
Actually, uploading objects to MediaExport is broken since more than one year while fixing DLNA compatibility for the N9