After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683025 - Contacts in groups are duplicated
Contacts in groups are duplicated
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.33.x
Other Linux
: Normal normal
: 3.6
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 10:06 UTC by Guillaume Desmottes
Modified: 2012-08-30 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
roster-view: make sure the same contact isn't added twice to the same group (1.23 KB, patch)
2012-08-30 10:08 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2012-08-30 10:06:23 UTC
When restarting Empathy once the accounts are connected, all the contacts in group (except the top one) appears twice.
Comment 1 Guillaume Desmottes 2012-08-30 10:08:53 UTC
Created attachment 222918 [details] [review]
roster-view: make sure the same contact isn't added twice to the same group

Calling empathy_roster_model_get_groups_for_individual() in individual_added
may have the side effect for folks to discover the contact's groups and so
fire a bunch of signals leading us to add the contact in the group.
Then we look for his groups in individual_added() and re-add him a second
time.

Fix this by making sure we won't add the same contact twice to the same group.
Comment 2 Xavier Claessens 2012-08-30 10:15:40 UTC
+1
Comment 3 Guillaume Desmottes 2012-08-30 10:17:18 UTC
Attachment 222918 [details] pushed as c11c1cb - roster-view: make sure the same contact isn't added twice to the same group