After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683024 - Entering and exiting overview have inconsistent key behaviour
Entering and exiting overview have inconsistent key behaviour
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 08:58 UTC by Justin
Modified: 2012-11-08 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main: hide the overview on key release (4.99 KB, patch)
2012-11-04 17:36 UTC, Stéphane Démurget
committed Details | Review

Description Justin 2012-08-30 08:58:03 UTC
To enter the overview, the action is set to key release. The meta/window key have to be pressed and released for the overview to kick in. If we keep the key pressed, overview is not displayed (until key is released). This kind of causes a feeling that the overview is slow/taking time/memory intensive.

But when exiting the overview, the action is set to keypress. The overview is exitied when we press the key and feels a lot faster.

Please make it consistent by setting the enter overview action to keypress.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-30 09:01:03 UTC
This would prevent people from typing shortcuts that begin with <Super>
Comment 2 Giovanni Campagna 2012-08-30 11:16:29 UTC
We could it make consistent on the other way round, and exit the overview on release.
Among other things, shortcuts ought to work in the overview...
Comment 3 Justin 2012-08-30 16:13:48 UTC
I agree, shortcuts are unavoidable. Exit on key release would be better, I guess.
Comment 4 Justin 2012-11-04 13:54:43 UTC
Any progress here?
Comment 5 Stéphane Démurget 2012-11-04 17:36:38 UTC
Created attachment 228035 [details] [review]
main: hide the overview on key release

Entering the overview with the overlay key is done on key release but
exiting the overview on key press, which is inconsistent.

This change makes the overview hidden also on key release.
Comment 6 Allan Day 2012-11-04 19:22:47 UTC
Thanks for the patch Stéphane! It works well here.
Comment 7 Giovanni Campagna 2012-11-05 18:05:56 UTC
Review of attachment 228035 [details] [review]:

LGTM
Comment 8 Stéphane Démurget 2012-11-05 20:53:13 UTC
Comment on attachment 228035 [details] [review]
main: hide the overview on key release

Pushed as 6e4c89b3101259275694eb3112d05ab005aec117

(git-bz push did not update the bug? I'll double check next time)
Comment 9 Stéphane Démurget 2012-11-05 21:00:31 UTC
Comment on attachment 228035 [details] [review]
main: hide the overview on key release

Ok (I was missing priviledges)
Comment 10 Mantas Mikulėnas (grawity) 2012-11-08 15:00:03 UTC
Unfortunately, this change conflicts with an earlier commit dd3484b93f3f846c98a331bdc7243f91d57b6ac8 "dash: Open 'Show Apps' with Super+A", since it makes the overview open and almost-immediately close again.
Comment 11 Stéphane Démurget 2012-11-08 15:07:28 UTC
(In reply to comment #10)
> Unfortunately, this change conflicts with an earlier commit
> dd3484b93f3f846c98a331bdc7243f91d57b6ac8 "dash: Open 'Show Apps' with Super+A",
> since it makes the overview open and almost-immediately close again.

This is bug 687922.