After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683022 - Only favorite top contact should be displayed when offline
Only favorite top contact should be displayed when offline
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.33.x
Other Linux
: Normal normal
: 3.6
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 08:04 UTC by Guillaume Desmottes
Modified: 2012-09-04 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
model-manager: connect on the "favourites-changed" signal (1.16 KB, patch)
2012-08-30 09:21 UTC, Guillaume Desmottes 		committed Details | Review
roster-view: don't display offline not favorite top contacts (2.92 KB, patch)
2012-08-30 09:21 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-08-30 08:04:53 UTC 
When refactoring the new roster code we accidentally break the old logic in the top contacts group. Only *favorite* contacts should be displayed when they are offline not the most used contacts.
Comment 1 Guillaume Desmottes 2012-08-30 09:21:11 UTC 
Created attachment 222916 [details] [review]
model-manager: connect on the "favourites-changed" signal

That's a proper signal, not a property change.
Comment 2 Guillaume Desmottes 2012-08-30 09:21:13 UTC 
Created attachment 222917 [details] [review]
roster-view: don't display offline not favorite top contacts

We just want to always display the favorites offline contacts in the top
contact section.

One may say that we are kinda breaking the model group abstraction, which is
probably true. Ideally we may want to have a roster view subclass implementing
the top contact logic but life is too short.
Comment 3 Guillaume Desmottes 2012-09-04 08:09:06 UTC 
Attachment 222916 [details] pushed as 53c73e0 - model-manager: connect on the "favourites-changed" signal
Attachment 222917 [details] pushed as 6d5797f - roster-view: don't display offline not favorite top contacts