After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683015 - st-im-text: Support surrounding-text.
st-im-text: Support surrounding-text.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 03:38 UTC by Daiki Ueno
Modified: 2012-08-31 00:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st-im-text: Support surrounding-text. (3.53 KB, patch)
2012-08-30 03:38 UTC, Daiki Ueno
committed Details | Review

Description Daiki Ueno 2012-08-30 03:38:51 UTC
So, now that StIMText has pre-edit support, it might make sense to support surrounding text as well.  I don't think this is a priority for 3.6, but the implementation is straightforward.

Test case:
- go to gnome-shell tests directory and run ./run-test.sh interactive/entry.js
- enable "Thai (kesmanee (m17n))" input source somehow
- type "mmmmmm", and you will get "ทททททท"
- move cursor by mouse and type "u", then character under cursor changes to "ที"
Comment 1 Daiki Ueno 2012-08-30 03:38:53 UTC
Created attachment 222909 [details] [review]
st-im-text: Support surrounding-text.
Comment 2 Rui Matos 2012-08-31 00:13:47 UTC
Review of attachment 222909 [details] [review]:

Looks good. Thanks