After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683001 - Make headings bold in message dialogs by default
Make headings bold in message dialogs by default
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-08-29 22:40 UTC by William Jon McCann
Modified: 2012-08-30 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
message dialog with no secondary text (before) (12.87 KB, image/png)
2012-08-29 22:40 UTC, William Jon McCann
  Details
Always make primary headings bold in message dialogs (2.34 KB, patch)
2012-08-29 22:40 UTC, William Jon McCann
committed Details | Review
message dialog with no secondary text (after) (13.17 KB, image/png)
2012-08-29 22:41 UTC, William Jon McCann
  Details

Description William Jon McCann 2012-08-29 22:40:07 UTC
Created attachment 222888 [details]
message dialog with no secondary text (before)

Currently we only make headings bold in message dialogs if the caller adds secondary text. I think it would be better if the dialogs would consistently use boldface for the headings since they are always headings and shouldn't vary in weight.

However, I think it probably makes sense to continue to only make the primary heading <big> when there is a secondary label shown.

The logic to me is that bold is for headings. Both dialogs with and without secondary text have headings. The <big> may be useful for differentiating primary and secondary text but it is unnecessary with only one label.

And visually I think that without the boldface the text gets lost in the window (particularly when there is a dialog image) and the eye isn't propertly guided to the question they need to answer. It feels wrong.
Comment 1 William Jon McCann 2012-08-29 22:40:51 UTC
Created attachment 222889 [details] [review]
Always make primary headings bold in message dialogs

Unless they have markup. But only use big text if there is
secondary text.
Comment 2 William Jon McCann 2012-08-29 22:41:19 UTC
Created attachment 222890 [details]
message dialog with no secondary text (after)
Comment 3 William Jon McCann 2012-08-29 22:41:53 UTC
Jakub, what do you think?
Comment 4 Jakub Steiner 2012-08-30 12:07:59 UTC
I agree
Comment 5 Matthias Clasen 2012-08-30 17:12:41 UTC
Review of attachment 222889 [details] [review]:

ok then. I think this may cause some minor fallout in application message dialogs, but I guess we will hear about that
Comment 6 William Jon McCann 2012-08-30 18:10:45 UTC
Attachment 222889 [details] pushed as 9fa1b4f - Always make primary headings bold in message dialogs