After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682998 - PopupMenu: propagate all open-state-changed down to PopupMenuSection
PopupMenu: propagate all open-state-changed down to PopupMenuSection
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-29 22:14 UTC by Giovanni Campagna
Modified: 2012-08-29 23:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PopupMenu: propagate all open-state-changed down to PopupMenuSection (2.11 KB, patch)
2012-08-29 22:14 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-08-29 22:14:19 UTC 
Fixes a stray separator after the volume menu was made into a section.
Comment 1 Giovanni Campagna 2012-08-29 22:14:22 UTC 
Created attachment 222884 [details] [review]
PopupMenu: propagate all open-state-changed down to PopupMenuSection

PopupMenuBase relies on open-state-changed to update the separator
visibility, but PopupMenuSection were only emitting when the parent
closed, so the first time the menu was opened, separator visiblity was
wrong.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-08-29 22:26:27 UTC 
Review of attachment 222884 [details] [review]:

Sure.
Comment 3 Giovanni Campagna 2012-08-29 23:48:48 UTC 
Attachment 222884 [details] pushed as 04d1a35 - PopupMenu: propagate all open-state-changed down to PopupMenuSection