After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682990 - Some build warning fixes
Some build warning fixes
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-29 21:09 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-09-04 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afp: Fix error message (-Wformat-security) (965 bytes, patch)
2012-08-29 21:09 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
http: Don't use deprecated libsoup methods (1.29 KB, patch)
2012-08-29 21:09 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dav: Don't use deprecated libsoup methods (2.46 KB, patch)
2012-08-30 10:22 UTC, Tomas Bzatek 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-08-29 21:09:23 UTC 
A -Wformat-security fix, and a deprecated method fix.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-29 21:09:25 UTC 
Created attachment 222861 [details] [review]
afp: Fix error message (-Wformat-security)

We need to supply an %s somewhere in here to be secure.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-08-29 21:09:28 UTC 
Created attachment 222862 [details] [review]
http: Don't use deprecated libsoup methods

soup_message_headers_get() has been deprecated in favor of
soup_message_headers_get_one().
Comment 3 Tomas Bzatek 2012-08-30 10:05:01 UTC 
Review of attachment 222861 [details] [review]:

Looks good, we're in String Change Announcement Period, please notify translators there's been a change in translatable string.
Comment 4 Tomas Bzatek 2012-08-30 10:12:48 UTC 
Review of attachment 222862 [details] [review]:

Right, came across this yesterday as well.
Comment 5 Tomas Bzatek 2012-08-30 10:22:52 UTC 
Created attachment 222920 [details] [review]
dav: Don't use deprecated libsoup methods

One more patch from me
Comment 6 Tomas Bzatek 2012-09-04 16:24:29 UTC 
Committed all three patches to git master.