After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682968 - Conflicting versions of AM_GST_ELEMENT_CHECK
Conflicting versions of AM_GST_ELEMENT_CHECK
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.11.x
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-29 17:52 UTC by Bastien Nocera
Modified: 2012-09-01 22:33 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2012-08-29 17:52:51 UTC
AM_GST_ELEMENT_CHECK() is in both GStreamer 0.10 and GStreamer 1.0, and checks for plugins using gst-inspect-0.10 or gst-inspect-1.0 depending on the version.

This breaks sound-juicer's build for example, which migth end up checking for GStreamer 0.10 packages depending on how it was dist'ed.
Comment 1 Bastien Nocera 2012-08-29 17:53:56 UTC
Possible fix includes defining a AM_GST_ELEMENT_CHECK2 which would check for a particular API version.

eg:
AM_GST_ELEMENT_CHECK2(API-VERSION, ELEMENT-NAME, ACTION-IF-FOUND, ACTION-IF-NOT-FOUND)
Comment 2 Tim-Philipp Müller 2012-08-29 18:15:03 UTC
Is the AM_ prefix is necessary or customary ? If not, we could just make the new one GST_ELEMENT_CHECK or GSTREAMER_ELEMENT_CHECK or something like that ?

Or maybe we should just drop it and rely on run-time checks instead ? (how useful is it actually ? is it helpful/good/desirable, e.g. for packagers, to make things a build dependency that's only a runtime dependency in practice ?)
Comment 3 Bastien Nocera 2012-08-29 18:21:40 UTC
It's certainly useful for packagers. They're smart enough to realise that the cdparanoia plugin is only useful for actually running the application, not for compiling it, and they'll adjust the dependencies of the packages as needed.
Comment 4 Bastien Nocera 2012-08-29 18:22:10 UTC
And yes we can remove the "AM_" prefix. They probably don't like us trampling on their namespace.
Comment 5 Tim-Philipp Müller 2012-09-01 22:33:27 UTC
Not actually tested:

 commit 8cd5813fa661d262159787c75a5695bde7df237d
 Author: Tim-Philipp Müller <tim@centricular.net>
 Date:   Sat Sep 1 18:06:58 2012 +0100

    gst-element-check.m4: rename AM_GST_ELEMENT_CHECK to GST_ELEMENT_CHECK
    
    And allow passing of a minimum version (if not needed, pass 1.0).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=682968