After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682944 - Allow NULL to be passed to g_object_ref/unref and friends
Allow NULL to be passed to g_object_ref/unref and friends
Status: RESOLVED DUPLICATE of bug 548953
Product: glib
Classification: Platform
Component: gobject
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-08-29 13:49 UTC by Behdad Esfahbod
Modified: 2012-08-29 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Behdad Esfahbod 2012-08-29 13:49:43 UTC 
Makes code more readable.  Say, I have to write this right now:

        PangoFontMap *fontmap = g_weak_ref_get ((GWeakRef *) &fcfont->fontmap);
        g_value_set_object (value, fontmap);
        if (fontmap)
          g_object_unref (fontmap);


Would have been nicer not have to do the check.
Comment 1 Emmanuele Bassi (:ebassi) 2012-08-29 14:03:59 UTC 
you already filed this bug :-)

it actually has been filed again and closed as WONTFIX if I remember correctly.

*** This bug has been marked as a duplicate of bug 548953 ***
Comment 2 Behdad Esfahbod 2012-08-29 14:09:29 UTC 
Haha.  I expected WONTFIX in fact, but still...
Comment 3 Christian Persch 2012-08-29 20:20:27 UTC 
        g_value_set_object (value, fontmap);
        if (fontmap)
          g_object_unref (fontmap);

-> g_value_take_object()... even saves the extra ref/unref.
Comment 4 Behdad Esfahbod 2012-08-29 20:23:09 UTC 
Ah, thanks.