GNOME Bugzilla – Bug 682934
fedora: be more resilient to express install setup failures
Last modified: 2016-03-31 14:01:26 UTC
Currently, if we fail to extract the kernel/initrd from the fedora ISO when we are attempting an unattended install, the whole box creation will fail. However, such errors are not that fatals, and non-unattended installs will work. In case of failures during unattended install setup, this patch will disable automatic installation, and will start a regular installation instead.
Created attachment 222730 [details] [review] fedora: be more resilient to express install setup failures
Just a proof of concept for now to get feedback about this approach, error message needs improving.
Review of attachment 222730 [details] [review]: Looks like the right thing to do, otherwise.. ::: src/fedora-installer.vala @@ +62,3 @@ + } catch (GLib.Error error) { + //FIXME cleanup extract boot files + App.app.notificationbar.display_error (_("Failed to setup Fedora express installation, disabling express installation")); * Either ". Disabling express installation..." or ". Disabled express installation." would be more correct IMO. * We'll have to announce this string change. * You want to dump the error on the console.
Created attachment 222942 [details] [review] Unattended install preparation errors should be non fatal When an error occurs during unattended installation preparation, it's still highly likely that we can go on with non-express installation. This commit catches errors in prepare_for_installation and falls back to trying a non-express install when an error occurs during preparation.
I've tested this new patch with win7, winxp (by changing the mcopy call to the name of an invalid command) and fedora (by changing the call to fuseiso to an invalid command). It makes more sense to handle this fallback at a higher level rather than having it in fedora-installer.vala.
Review of attachment 222942 [details] [review]: ACK with or without comment corrected (its still very much readable to me at least). ::: src/unattended-installer.vala @@ +150,3 @@ + // but it's likely that a non-unattended installation will + // work, so just disable unattended installs, and let the calling + // decide if it wants to retry a non-automatic install, or to just stop * Way too many commas (you don't put a commad before 'and' in English) * calling -> caller
Created attachment 222952 [details] [review] Unattended install preparation errors should be non fatal When an error occurs during unattended installation preparation, it's still highly likely that we can go on with non-express installation. This commit catches errors in prepare_for_installation and falls back to trying a non-express install when an error occurs during preparation.
Review of attachment 222952 [details] [review]: ACK
Attachment 222952 [details] pushed as 07c0020 - Unattended install preparation errors should be non fatal