After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682905 - Port to new documentation infrastructure
Port to new documentation infrastructure
Product: accerciser
Classification: Applications
Component: documentation
Other Linux
: Normal normal
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks: 681609
Reported: 2012-08-28 22:24 UTC by Oliver Propst
Modified: 2012-09-03 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (4.36 KB, patch)
2012-08-28 22:24 UTC, Oliver Propst
needs-work Details | Review
patchV2 (4.18 KB, patch)
2012-09-03 13:37 UTC, Oliver Propst
committed Details | Review

Description Oliver Propst 2012-08-28 22:24:14 UTC
Created attachment 222686 [details] [review]

Use yelp-tools instead of gnome-doc-utils
Comment 1 Javier Hernández 2012-09-03 09:36:59 UTC
Review of attachment 222686 [details] [review]:

Hi Oliver!!

Thanks for providing this patch! I'd like to mention a few things that needs work before this patch can be commited.

I applied it and I saw that now accerciser doensn't compile properly, and this is caused for two reasons:

+++ b/help/
@@ -32,6 +33,6 @@ 
+HELP_LINGUAS  = ca cs de el en_GB es fr gl it ja oc pl pt_BR sl sv uk zh_CN

You're defining the HELP_EXTRA and putting a "\" assuming that you're going to add some elements to it, but you aren't. So I think this should be removed.

+++ b/help/
@@ -1,7 +1,8 @@

I think you should add @YELP_HELP_RULES@ instead.

+++ b/
@@ -3,5 +3,14 @@
+GNOMEDOC=`which yelp-build`
+if test -z $GNOMEDOC; then
+echo "*** The tools to build the documentation are not found,"
+- echo " please intall the gnome-doc-utils package ***"
++ echo " please intall the yelp-tool package ***"
+exit 1

We don't want to stop the compilation here since a user can skip the build of the documentation.

+++ b/
@@ -22,12 +22,10 @@

-	--disable-scrollkeeper \

I'm not completely sure if we want to remove this option. Why did you remove it?

Thanks again for your help!

Comment 2 Oliver Propst 2012-09-03 13:37:16 UTC
Created attachment 223319 [details] [review]
Comment 3 Oliver Propst 2012-09-03 13:39:42 UTC
Sorry for my mistakes. The reason I deleted the --disable-scrollkeeper instruction was because scrollkeeper is not used anymore, but I guess it was unnecessary.
Comment 4 Javier Hernández 2012-09-03 23:44:04 UTC
Review of attachment 223319 [details] [review]:

Thanks Oliver!

Looks better now, I did some slightly modifications and I've just pushed to master [1]