After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682864 - region: Don't use IBus if running in fallback mode
region: Don't use IBus if running in fallback mode
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-28 10:22 UTC by Rui Matos
Modified: 2012-08-28 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: Use a filter model on input sources (12.34 KB, patch)
2012-08-28 10:22 UTC, Rui Matos 		committed Details | Review
region: Don't use IBus if running in fallback mode (3.12 KB, patch)
2012-08-28 10:22 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-08-28 10:22:08 UTC 
Patches attached.
Comment 1 Rui Matos 2012-08-28 10:22:14 UTC 
Created attachment 222618 [details] [review]
region: Use a filter model on input sources

This allows us to hide some entries which for whatever reason we can't
display without removing them from gsettings.

This reverts commit 54835c8f4486309c1517a7f71735fbdd7e098c5f.
This reverts commit 953cc81b0f07c0e5f4e1f34a139efafe6d61fea1.
This reverts commit ab0594239c5e43b3a14a0cf40ab2cce039a17a53.
This reverts commit 03f08fd36c059c17f3af723ca29e0ad931fc6a26.
Comment 2 Rui Matos 2012-08-28 10:22:17 UTC 
Created attachment 222619 [details] [review]
region: Don't use IBus if running in fallback mode

In fallback mode we don't want to touch IBus since the gnome-shell UI
isn't there to provide the full integrated user experience.

We expect users to continue using existing IBus UIs in fallback mode.
Comment 3 Bastien Nocera 2012-08-28 11:51:10 UTC 
Review of attachment 222619 [details] [review]:

It's pretty broken if gnome-shell happens to restart for example, but I guess it's good enough for what it is.
Comment 4 Rui Matos 2012-08-28 11:55:10 UTC 
(In reply to comment #3)
> It's pretty broken if gnome-shell happens to restart for example, but I guess
> it's good enough for what it is.

I don't think so. If the shell restarts, the handler is a essentially a nop.
Comment 5 Rui Matos 2012-08-28 13:06:18 UTC 
I take it that the other patch is implicitly acked as it is merely
reverting stuff.

Attachment 222618 [details] pushed as dee8e09 - region: Use a filter model on input sources
Attachment 222619 [details] pushed as 658083f - region: Don't use IBus if running in fallback mode