After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682824 - Don't build gtk-launch when gio-unix is not available
Don't build gtk-launch when gio-unix is not available
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.5.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-08-27 20:34 UTC by Erik van Pienbroek
Modified: 2013-05-01 05:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1010 bytes, patch)
2012-08-27 20:34 UTC, Erik van Pienbroek 		needs-work Details | Review
Updated patch (1.23 KB, patch)
2013-01-27 14:41 UTC, Erik van Pienbroek 		accepted-commit_now Details | Review
Revert "Don't build gtk-launch when gio-unix is not available" (1.55 KB, patch)
2013-04-30 14:19 UTC, Hib Eris 		none Details | Review
Revert "Don't build gtk-launch when gio-unix is not available" - gtk-3.8 branch (1.50 KB, patch)
2013-04-30 14:39 UTC, Erik van Pienbroek 		none Details | Review

Description Erik van Pienbroek 2012-08-27 20:34:53 UTC 
Created attachment 222578 [details] [review]
Proposed patch

Don't build gtk-launch on Win32 environments

The gtk-launch tool depends on gio-unix which isn't available on Win32
Comment 1 Xavier Claessens 2012-08-29 11:21:37 UTC 
This happens when building only broadway backend as well. In that case configure.ac does not set have_gio_unix. I guess broadway backend can be built on win32 so it makes sense.
Comment 2 Matthias Clasen 2012-08-30 17:08:50 UTC 
Review of attachment 222578 [details] [review]:

I guess the conditional is not quite right then; it should really go by the availability of gio-unix
Comment 3 Erik van Pienbroek 2013-01-27 14:41:28 UTC 
Created attachment 234531 [details] [review]
Updated patch

This updated patch only builds gtk-launch when gio-unix is available (in the previous patch the win32 target was used as conditional)
Comment 4 Matthias Clasen 2013-01-28 12:41:23 UTC 
Review of attachment 234531 [details] [review]:

ok
Comment 5 Hib Eris 2013-04-30 14:10:40 UTC 
Since commit 99e194e7cc76c420c42562e2c77876d225975430 the gtk-launch tool can be build without gio-unix (although it will not really do much without an alternative implementation for g_desktop_app_info).

So there is no need to not build gtk-launch anymore.
Erik, would you it be okay to revert your patch 9a1235bf0dbdb1701779bec0ccae043cc4243ce5 ?
Comment 6 Hib Eris 2013-04-30 14:11:45 UTC 
The commit I'd like to revert is commit 9a1235bf0dbdb1701779bec0ccae043cc4243ce5
Comment 7 Erik van Pienbroek 2013-04-30 14:14:45 UTC 
If it doesn't break win32 compilation, sure, go ahead
Comment 8 Hib Eris 2013-04-30 14:19:53 UTC 
Created attachment 242918 [details] [review]
Revert "Don't build gtk-launch when gio-unix is not available"

The gtk-launch tool can be build without gio-unix (although it
will not really do much without an alternative implementation for
g_desktop_app_info).

So there is no need to not build gtk-launch anymore.

This reverts commit 9a1235bf0dbdb1701779bec0ccae043cc4243ce5.
Comment 9 Erik van Pienbroek 2013-04-30 14:39:07 UTC 
Created attachment 242921 [details] [review]
Revert "Don't build gtk-launch when gio-unix is not available" - gtk-3.8 branch

I just tested your patch against gtk 3.8.1 (as there are no gtk 3.9 releases done yet). It required a minor change to get it applied against the gtk-3.8 branch. I attached the updated patch to this ticket. With it gtk-launch can be compiled without issues. Feel free to apply this patch to the gtk-3.8 branch
Comment 10 Matthias Clasen 2013-05-01 01:32:35 UTC 
fine with me, fwiw
Comment 11 Hib Eris 2013-05-01 05:47:25 UTC 
commited.

commit	4dcd49352b61d91796a2628666a0c9dfc5fdb2fd (master)
commit	4380ce84958d78d912180353fa939feec8f30edc (gtk-3-8)