After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682808 - Fix misuse of N_()
Fix misuse of N_()
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-27 15:28 UTC by Christophe Fergeau
Modified: 2016-03-31 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix misuse of N_() (2.87 KB, patch)
2012-08-27 15:28 UTC, Christophe Fergeau
committed Details | Review

Description Christophe Fergeau 2012-08-27 15:28:28 UTC
There are a few places where N_() is used without calling gettext()
on the returned string. However, glib documentation for N_() says:
"Only marks a string for translation. This is useful in situations where
the translated strings can't be directly used, e.g. in string array
initializers. To get the translated string, call gettext() at runtime."

Since these uses are in places where _() can safely be called,
use that instead.
Comment 1 Christophe Fergeau 2012-08-27 15:28:30 UTC
Created attachment 222560 [details] [review]
Fix misuse of N_()
Comment 2 Marc-Andre Lureau 2012-08-27 15:40:17 UTC
Review of attachment 222560 [details] [review]:

ack
Comment 3 Christophe Fergeau 2012-08-28 13:01:01 UTC
Attachment 222560 [details] pushed as f43ac67 - Fix misuse of N_()