After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682778 - Gnomine 3.5.90: the timer is not stopped at the end of the game
Gnomine 3.5.90: the timer is not stopped at the end of the game
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnomine
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-27 10:02 UTC by Matthieu Baerts
Modified: 2012-08-28 08:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Gnomine: the timer is not stopped at the end (2.22 KB, patch)
2012-08-27 10:20 UTC, Matthieu Baerts 		committed Details | Review

Description Matthieu Baerts 2012-08-27 10:02:27 UTC 
Hello,

First, thank you for developing all these games!

I have a bug with the 3.5.90 version of Gnomine (and not with the previous version but I'm not sure): the timer is not stopped at the end of the game.

Also, if I click on 'New Game' at the end of the game, I have this warning on the terminal:
    (gnomine:5123): GLib-CRITICAL **: g_timer_continue: assertion `timer->active == FALSE' failed

I have a patch. It will be added asap ;)
Comment 1 Matthieu Baerts 2012-08-27 10:20:05 UTC 
Created attachment 222520 [details] [review]
Gnomine: the timer is not stopped at the end

This is the patch: Gnomine: the timer is not stopped at the end

minefield.vala: The new timer is not stopped at the end of the game.

gnomine.vale: If we click on 'New Game' when we are playing, the timer continue and there is this warning if we accept to quit the game:
 GLib-CRITICAL **: g_timer_continue: assertion `timer->active == FALSE' failed

In this situation, I guess it's maybe better to pause the game by using 'toggle_pause_cb ()' except if we just prefer stopping the game if the user accepts to quit the game.
Comment 2 Robert Ancell 2012-08-27 21:34:05 UTC 
Review of attachment 222520 [details] [review]:

Thanks Matthieu!
Comment 3 Robert Ancell 2012-08-27 21:34:16 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Matthieu Baerts 2012-08-28 08:50:16 UTC 
Thank you for this quick answer! :)