GNOME Bugzilla – Bug 682777
Port to new documentation infrastructure
Last modified: 2012-09-14 23:23:37 UTC
Created attachment 222519 [details] [review] patch See https://live.gnome.org/GnomeGoals/NewDocumentationInfrastructure
Created attachment 222559 [details] [review] patch
Review of attachment 222559 [details] [review]: Some comments: Instead of removing gnome-nettool.xml and creating a new one with exactly the same content, it is better to use 'git mv'. Also, when renaming files that are being translated, it is necessary to update the translation files. Otherwise, the translator will translate something that was already translated. In this, the following could have been done to alleviate the problem: $ for i in $(find help -name '*.po'); do sed -i 's|C/gnome-nettool.xml|C/index.docbook|g' $i;done It is also good to run make distcheck to test if it builds properly. ::: help/Makefile.am @@ +7,3 @@ + legal.xml + +HELP_MEDIA = \ The backslash is not needed here. It adds a warning in the build process. @@ +9,3 @@ +HELP_MEDIA = \ + +HELP_EXTRA = \ Same here. No backslash needed,
I made the changes commented and I applied the patch. Check http://git.gnome.org/browse/gnome-nettool/commit/?id=a1c0323989530e1476a886ab70afbea695d17165 to see the differences with the patch originally proposed.
Thanks for reviewing the patch (and commit it with the necessary changes).
Created attachment 223519 [details] [review] legal.xml patch
I forgot to add a correct help reference in /help/C/legal.xml, the patch above fixes that.