After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682777 - Port to new documentation infrastructure
Port to new documentation infrastructure
Product: gnome-nettool
Classification: Applications
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
Depends on:
Blocks: 681609
Reported: 2012-08-27 09:59 UTC by Oliver Propst
Modified: 2012-09-14 23:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (6.63 KB, patch)
2012-08-27 09:59 UTC, Oliver Propst
none Details | Review
patch (10.43 KB, patch)
2012-08-27 15:22 UTC, Oliver Propst
reviewed Details | Review
legal.xml patch (1.01 KB, patch)
2012-09-05 11:30 UTC, Oliver Propst
committed Details | Review

Comment 1 Oliver Propst 2012-08-27 15:22:21 UTC
Created attachment 222559 [details] [review]
Comment 2 Germán Poo-Caamaño 2012-09-03 21:05:54 UTC
Review of attachment 222559 [details] [review]:

Some comments:

Instead of removing gnome-nettool.xml and creating a new one 
with exactly the same content, it is better to use 'git mv'.

Also, when renaming files that are being translated, it is
necessary to update the translation files.  Otherwise, the
translator will translate something that was already
translated.  In this, the following could have been done to
alleviate the problem:

$ for i in $(find help -name '*.po'); do sed -i 's|C/gnome-nettool.xml|C/index.docbook|g' $i;done

It is also good to run make distcheck to test if it builds

::: help/
@@ +7,3 @@
+	legal.xml

The backslash is not needed here. It adds
a warning in the build process.

@@ +9,3 @@

Same here.  No backslash needed,
Comment 3 Germán Poo-Caamaño 2012-09-03 21:08:11 UTC
I made the changes commented and I applied the patch.  Check
to see the differences with the patch originally proposed.
Comment 4 Oliver Propst 2012-09-03 21:24:28 UTC
Thanks for reviewing the patch (and commit it with the necessary changes).
Comment 5 Oliver Propst 2012-09-05 11:30:12 UTC
Created attachment 223519 [details] [review]
legal.xml patch
Comment 6 Oliver Propst 2012-09-05 11:31:53 UTC
I forgot to add a correct help reference in /help/C/legal.xml, the patch above fixes that.