GNOME Bugzilla – Bug 682758
gdm 3.5.90 has wrong gvariant for on_seat_new and on_seat_remove
Last modified: 2012-08-30 19:33:35 UTC
Since the GDBus port dddeab1c9223cc5d8427217846faa2b40e45c116 the on_seat_new and on_seat_removed g_variant_get for the wrong types. the message is actually a tuple of a string + object path, not just a single string.
Created attachment 222510 [details] [review] proposed patch This seems to work here.
Review of attachment 222510 [details] [review]: ::: gdm-3.5.90/daemon/gdm-local-display-factory.c.dave @@ +454,1 @@ + g_variant_get (parameters, "(so)", &seat, &obj_path); You're leaking seat and obj_path here. Use "(&s&o)" instead (or pass NULL in place of obj_path)
Created attachment 222910 [details] [review] proposed patch 2
Review of attachment 222910 [details] [review]: LGTM
The following fix has been pushed: 25b8703 Use correct types in on_seat_new and on_seat_removed
Created attachment 222982 [details] [review] Use correct types in on_seat_new and on_seat_removed The message is actually a tuple of a string + object path, not just a single string.