After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682749 - Update goffice locales picker
Update goffice locales picker
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: Gtk+
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2012-08-26 23:26 UTC by Chris Leonard
Modified: 2012-09-27 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
list of glibc versus goffice locales (4.45 KB, text/plain)
2012-08-26 23:30 UTC, Chris Leonard
  Details
Draft locale patch (21.58 KB, patch)
2012-08-28 01:58 UTC, Chris Leonard
none Details | Review

Description Chris Leonard 2012-08-26 23:26:29 UTC
The goffice/gtk/go-locale-sel.c file is in need of updating to the currently available locales.  See the attached spreadsheet for a comparison of the lists.

I'm not asking you to do this work, I'm interested in trying to provide a patch for it myself, but I need some guidance.

Most of these are straightforward additions of new locales, but I have some questions:

1) I think these are easy enough to sort out, but I wanted to mention them.

fix iw_IL to he_IL

fix no_NO to nb_NO

fix sr_YU to sr_RS

eo_EO (no Esperanto locale in glibc), I'll just leave this alone for now.


2) How do you want to handle the Eurozone currency variants?

br_FR 
br_FR@euro

and many other pairs like this.

3)  How do you want to handle script variants, like these and others?

aa_ER
aa_ER@saaho

be_BY
be_BY@latin

gez_ER
gez_ER@abegede
gez_ET
gez_ET@abegede

ks_IN
ks_IN@devanagari
sd_IN
sd_IN@devanagari

tt_RU
tt_RU@iqtelif

uz_UZ
uz_UZ@cyrillic
Comment 1 Chris Leonard 2012-08-26 23:30:18 UTC
Created attachment 222503 [details]
list of glibc versus goffice locales
Comment 2 Jean Bréfort 2012-08-27 09:43:03 UTC
1: trivial
2: I don't think we need that given the use we make of this selector
3: I don't know.
Comment 3 Chris Leonard 2012-08-27 14:55:47 UTC
Thanks for the feedback Jean.  I'm working on the patch, will post here when it is ready for review.
Comment 4 Chris Leonard 2012-08-27 15:43:58 UTC
When available, it is possibly that this patch should be held until a patch for currency picker is also available.

Refresh of country/currency strings in /goffice/utils/formats.c
https://bugzilla.gnome.org/show_bug.cgi?id=682810
Comment 5 Chris Leonard 2012-08-28 01:58:10 UTC
Created attachment 222605 [details] [review]
Draft locale patch
Comment 6 Chris Leonard 2012-08-28 01:59:00 UTC
Regional Geographic Classification questions

Is Kazakhstan Asia or Eastern Europe? (currently set as Asia)

Macedonia is currently Eastern Europe, should it be Western Europe?

Moved a number of locales into previously unused LGroup LG_MIDDLE_EAST

Created New LGroup: LG_CARIBBEAN

Antigua and Barbuda/English (en_AG)
Costa Rica (es_CR)
Dominican Republic (es_DO)
Puerto Rico (es_PR)
Haiti/Kreyol (ht_HT)
Aruba/Dutch (nl_AW)
Netherland Antilles/Papiamento (pap_AN)
Comment 7 Jean Bréfort 2012-09-17 07:49:59 UTC
I'd say Kazakhstan is Asia and I'd keep Macedonia in Eastern Europe.
Comment 8 Chris Leonard 2012-09-17 08:43:22 UTC
Then the patch as submitted should be good to go.
Comment 9 Jean Bréfort 2012-09-27 09:28:29 UTC
Applying the patch breaks the build: missing and misplaced commas. Fixed these.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 10 Chris Leonard 2012-09-27 09:57:22 UTC
Sorry for the patch errors.  Thanks for the fix.