After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682735 - Don't try parsing libgweather strings
Don't try parsing libgweather strings
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-26 16:43 UTC by Giovanni Campagna
Modified: 2012-08-26 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't try parsing libgweather strings (1.47 KB, patch)
2012-08-26 16:43 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-08-26 16:43:28 UTC 
The output of gweather_info_get_sunrise/sunset() is localized. Instead,
use gweather_info_get_value_sunrise/get_value_sunset(), which gives directly
the time as a unix timestamp.
Comment 1 Giovanni Campagna 2012-08-26 16:43:31 UTC 
Created attachment 222482 [details] [review]
Don't try parsing libgweather strings
Comment 2 Paolo Borelli 2012-08-26 18:46:36 UTC 
Review of attachment 222482 [details] [review]:

Shouldn't we check that ok return value?

Anyway please commit
Comment 3 Giovanni Campagna 2012-08-26 19:32:56 UTC 
Attachment 222482 [details] pushed as 90b352e - Don't try parsing libgweather strings
There should be no need to check ok, as it depends only on the validity of
the info (which is guaranteed after updated is emitted)