After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682696 - Add keywords for better discoverability
Add keywords for better discoverability
Status: RESOLVED FIXED
Product: gnome-packagekit
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-25 21:36 UTC by Jeremy Bicha
Modified: 2012-10-29 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add keywords for better discoverability (1.06 KB, patch)
2012-08-25 21:36 UTC, Jeremy Bicha 		accepted-commit_now Details | Review

Description Jeremy Bicha 2012-08-25 21:36:34 UTC 
Keywords are used in places like Unity's Dash, GNOME's Application Overview, and Ubuntu Software Center.
Comment 1 Jeremy Bicha 2012-08-25 21:36:56 UTC 
Created attachment 222436 [details] [review]
Add keywords for better discoverability

Since Software now is the only default visible entry point to Updates
and editing Software Sources preferences, add keywords for those
apps too.

Keywords are used in places like Unity's Dash, GNOME's Application Overview,
and Ubuntu Software Center.

http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html#key-keywords
Comment 2 Jeremy Bicha 2012-08-25 21:39:14 UTC 
This is somewhat of a regression fix since someone who types "Update" into GNOME Shell's Activities Overview in 3.5.90 won't get any results but that worked for previous released.
Comment 3 Matthias Clasen 2012-08-25 21:57:40 UTC 
Review of attachment 222436 [details] [review]:

Not sure that Preferences is really right, but the rest clearly make sense.
Comment 4 Jeremy Bicha 2012-08-26 01:50:54 UTC 
gpk-prefs still calls itself "Software Update Preferences" in the title bar, but I agree that "preferences" isn't really needed.
Comment 5 André Klapper 2012-08-27 10:36:53 UTC 
Note that we're under String Announcement Period so notification to gnome-i18n@ would be needed.
Comment 6 Jeremy Bicha 2012-10-24 19:56:14 UTC 
Can I go ahead and commit this to master if I take out "Preferences" ?
Comment 7 Matthias Clasen 2012-10-25 17:23:30 UTC 
Yeah, lets just get this in - may need to branch first due to string change. Hughsie is back now, in any case.due
Comment 8 Richard Hughes 2012-10-29 14:57:06 UTC 
(In reply to comment #6)
> Can I go ahead and commit this to master if I take out "Preferences" ?

Yes please, thanks!
Comment 9 Richard Hughes 2012-10-29 14:57:36 UTC 
Review of attachment 222436 [details] [review]:

Agreed, remove Preferences and good to go. Thanks!