After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682672 - girepository: Add g_interface_info_find_signal
girepository: Add g_interface_info_find_signal
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-25 13:53 UTC by Torsten Schoenfeld
Modified: 2015-02-07 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
girepository: Add g_interface_info_find_signal (2.79 KB, patch)
2012-08-25 13:53 UTC, Torsten Schoenfeld
committed Details | Review

Description Torsten Schoenfeld 2012-08-25 13:53:51 UTC
This patch adds the convenience method g_interface_info_find_signal to
girepository to mirror g_object_info_find_signal.
Comment 1 Torsten Schoenfeld 2012-08-25 13:53:54 UTC
Created attachment 222397 [details] [review]
girepository: Add g_interface_info_find_signal
Comment 2 Colin Walters 2012-08-25 16:57:43 UTC
Review of attachment 222397 [details] [review]:

Makes sense to me.  One really really minor thing - even if a patch is very obvious I tend to put at least one sentence of motivation in the git log.  In this case just what you wrote in the bug report, like "Mirrors g_object_info_find_signal." is good enough.

Thanks!
Comment 3 Torsten Schoenfeld 2012-08-25 17:08:32 UTC
Committed with the commit message adjusted.  Thanks for the review!

Attachment 222397 [details] pushed as e80aedc - girepository: Add g_interface_info_find_signal
Comment 4 André Klapper 2015-02-07 16:58:01 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]