After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682647 - girepository: Fix leak in g_vfunc_info_get_address
girepository: Fix leak in g_vfunc_info_get_address
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-25 07:08 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2015-02-07 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
girepository: Fix leak in g_vfunc_info_get_address (1.48 KB, patch)
2012-08-25 07:08 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
girepository: Fix leak in g_vfunc_info_get_address (1.67 KB, patch)
2012-08-25 17:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-08-25 07:08:33 UTC 
See patch. Spotted by darkxst on IRC.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-25 07:08:35 UTC 
Created attachment 222377 [details] [review]
girepository: Fix leak in g_vfunc_info_get_address

We need to fix the struct info here.
Comment 2 Colin Walters 2012-08-25 17:01:31 UTC 
Review of attachment 222377 [details] [review]:

::: girepository/givfuncinfo.c
@@ +267,1 @@
       return NULL;

Doesn't this return need to change to "goto out" too?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-25 17:05:10 UTC 
Created attachment 222411 [details] [review]
girepository: Fix leak in g_vfunc_info_get_address

We need to fix the struct info here.



Good catch. Not sure how I missed that.
Comment 4 Colin Walters 2012-08-25 17:06:34 UTC 
Review of attachment 222411 [details] [review]:

Looks good.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-08-25 17:10:35 UTC 
Attachment 222411 [details] pushed as 1da728f - girepository: Fix leak in g_vfunc_info_get_address
Comment 6 André Klapper 2015-02-07 17:01:38 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]