After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682645 - very poor spacing in mount operation dialog
very poor spacing in mount operation dialog
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-25 00:31 UTC by William Jon McCann
Modified: 2012-08-28 01:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (591.82 KB, image/jpeg)
2012-08-25 00:31 UTC, William Jon McCann 		  Details
Fix the spacing in the mount operation auth prompt (1.45 KB, patch)
2012-08-27 23:03 UTC, William Jon McCann 		committed Details | Review
Add 1em of padding below the password box (687 bytes, patch)
2012-08-28 01:13 UTC, William Jon McCann 		committed Details | Review
Use the term password instead of passphrase (1.63 KB, patch)
2012-08-28 01:17 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-08-25 00:31:48 UTC 
Created attachment 222373 [details]
screenshot

Ver poor spacing in mount operation dialog. The label is actually touching the entry box and the label is not vertically aligned either.
Comment 1 William Jon McCann 2012-08-27 23:03:12 UTC 
Created attachment 222594 [details] [review]
Fix the spacing in the mount operation auth prompt

We weren't setting the correct style attributes like we
were in the polkit auth dialog.
Comment 2 William Jon McCann 2012-08-27 23:05:18 UTC 
I guess the one remaining, and separate, issue is that there should be a row of space between the entry box and the checkbox for remembering the passphrase.
Comment 3 William Jon McCann 2012-08-27 23:06:16 UTC 
One more issue actually. The prompt (primary) text asks for a password and the prompt asks for a passphrase.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-08-27 23:15:41 UTC 
Review of attachment 222594 [details] [review]:

Sigh. Good.
Comment 5 William Jon McCann 2012-08-28 00:42:52 UTC 
Attachment 222594 [details] pushed as b3cb9d8 - Fix the spacing in the mount operation auth prompt
Comment 6 William Jon McCann 2012-08-28 00:45:13 UTC 
Jasper, what is the recommended way to add that row of space I referred to in comment 2? A 1em bottom margin in the style of the password box?
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-08-28 00:55:46 UTC 
Sounds like it would work to me.
Comment 8 William Jon McCann 2012-08-28 01:13:39 UTC 
Created attachment 222600 [details] [review]
Add 1em of padding below the password box
Comment 9 William Jon McCann 2012-08-28 01:17:36 UTC 
Created attachment 222601 [details] [review]
Use the term password instead of passphrase

Since that is what the primary label uses as well as the gtk mount
operation.
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-08-28 01:20:58 UTC 
Review of attachment 222600 [details] [review]:

Sure.
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-08-28 01:21:12 UTC 
Review of attachment 222601 [details] [review]:

Let's get this in before string freeze.
Comment 12 William Jon McCann 2012-08-28 01:51:48 UTC 
Attachment 222600 [details] pushed as e34ab6c - Add 1em of padding below the password box
Attachment 222601 [details] pushed as 70d1953 - Use the term password instead of passphrase